Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RustWrapper: adapt for an LLVM API change #89766

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

krasimirgg
Copy link
Contributor

No functional changes intended.

The LLVM commit
llvm/llvm-project@89b5706
moved TargetRegistry.(h|cpp) from Support to MC.
This adapts RustWrapper accordingly.

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2021
@krasimirgg krasimirgg marked this pull request as ready for review October 11, 2021 11:37
@krasimirgg krasimirgg requested a review from nikic October 11, 2021 11:44
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
@nagisa
Copy link
Member

nagisa commented Oct 16, 2021

Could you please squash the two commits together? r=me once done.

@krasimirgg krasimirgg marked this pull request as draft October 18, 2021 07:40
No functional changes intended.

The LLVM commit
llvm/llvm-project@89b5706
moved TargetRegistry.(h|cpp) from Support to MC.
This adapts RustWrapper accordingly.
@krasimirgg krasimirgg marked this pull request as ready for review October 18, 2021 08:05
@krasimirgg
Copy link
Contributor Author

r=nagisa

@nikic
Copy link
Contributor

nikic commented Oct 18, 2021

@bors r=nagisa rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2021

📌 Commit e3c3f4a has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2021
… r=nagisa

RustWrapper: adapt for an LLVM API change

No functional changes intended.

The LLVM commit
llvm/llvm-project@89b5706
moved TargetRegistry.(h|cpp) from Support to MC.
This adapts RustWrapper accordingly.
This was referenced Oct 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2021
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89766 (RustWrapper: adapt for an LLVM API change)
 - rust-lang#89867 (Fix macro_rules! duplication when reexported in the same module)
 - rust-lang#89941 (removing TLS support in x86_64-unknown-none-hermitkernel)
 - rust-lang#89956 (Suggest a case insensitive match name regardless of levenshtein distance)
 - rust-lang#89988 (Do not promote values with const drop that need to be dropped)
 - rust-lang#89997 (Add test for issue rust-lang#84957 - `str.as_bytes()` in a `const` expression)
 - rust-lang#90002 (:arrow_up: rust-analyzer)
 - rust-lang#90034 (Tiny tweak to Iterator::unzip() doc comment example.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54aa547 into rust-lang:master Oct 19, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants