Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate projection sub-obligations #90423

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Deduplicate projection sub-obligations #90423

merged 3 commits into from
Dec 12, 2021

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 30, 2021
@bors
Copy link
Contributor

bors commented Oct 30, 2021

⌛ Trying commit 67da0ff with merge cb8c3c7f79618921c9e00796b8e06ca3cab56a7d...

@bors
Copy link
Contributor

bors commented Oct 30, 2021

☀️ Try build successful - checks-actions
Build commit: cb8c3c7f79618921c9e00796b8e06ca3cab56a7d (cb8c3c7f79618921c9e00796b8e06ca3cab56a7d)

@rust-timer
Copy link
Collaborator

Queued cb8c3c7f79618921c9e00796b8e06ca3cab56a7d with parent 9f13083, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cb8c3c7f79618921c9e00796b8e06ca3cab56a7d): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -7.7% on full builds of deeply-nested)
  • Moderate regression in instruction counts (up to 1.8% on full builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 30, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 30, 2021
@bors
Copy link
Contributor

bors commented Oct 30, 2021

⌛ Trying commit 851f2b2 with merge 09e9d70171a9e1fd087e1df3ba394cd042192e55...

@bors
Copy link
Contributor

bors commented Oct 31, 2021

☀️ Try build successful - checks-actions
Build commit: 09e9d70171a9e1fd087e1df3ba394cd042192e55 (09e9d70171a9e1fd087e1df3ba394cd042192e55)

@rust-timer
Copy link
Collaborator

Queued 09e9d70171a9e1fd087e1df3ba394cd042192e55 with parent e249ce6, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (09e9d70171a9e1fd087e1df3ba394cd042192e55): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -8.8% on full builds of deeply-nested)
  • Small regression in instruction counts (up to 1.0% on full builds of wg-grammar)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 31, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 31, 2021
@bors
Copy link
Contributor

bors commented Oct 31, 2021

⌛ Trying commit 39d44e7 with merge c40d55a7c903301595ddd3928033fcc9dcca2036...

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2021
@jackh726 jackh726 added the perf-regression-triaged The performance regression has been triaged. label Dec 9, 2021
@bors
Copy link
Contributor

bors commented Dec 12, 2021

⌛ Testing commit 39d44e7 with merge 4c9bdf4...

@bors
Copy link
Contributor

bors commented Dec 12, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 4c9bdf4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2021
@bors bors merged commit 4c9bdf4 into rust-lang:master Dec 12, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 12, 2021
@bors bors mentioned this pull request Dec 12, 2021
Closed
@Aaron1011 Aaron1011 mentioned this pull request Dec 12, 2021
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4c9bdf4): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -6.2% on full builds of deeply-nested)
  • Small regression in instruction counts (up to 0.5% on full builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@jackh726
Copy link
Member

I'm actually going to beta and stable nominate this. The perf regressions that this fixes are pretty bad.

@jackh726 jackh726 added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 13, 2021
@the8472 the8472 mentioned this pull request Dec 15, 2021
Closed
@pnkfelix
Copy link
Member

beta-accepted in tandem with #91065

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 16, 2021
@pnkfelix
Copy link
Member

declining for stable-backport.

@rustbot: -label: stable-nominated

@pnkfelix
Copy link
Member

@rustbot label: -stable-nominated

@rustbot rustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Dec 16, 2021
@olix0r olix0r mentioned this pull request Dec 21, 2021
Closed
@wesleywiser wesleywiser mentioned this pull request Dec 27, 2021
Closed
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 5, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.59.0, 1.58.0 Jan 5, 2022
This was referenced Jan 5, 2022
Merged
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2022
@bors
Auto merge of rust-lang#92592 - Mark-Simulacrum:beta-next, r=Mark-Sim…
4aa9d23 
…ulacrum

[beta] backports

Backports these PRs:

* Fix HashStable implementation on InferTy rust-lang#91892
* Revert setting a default for the MACOSX_DEPLOYMENT_TARGET env var for linking rust-lang#91870
* Make rustdoc headings black, and markdown blue rust-lang#91534
* Disable LLVM newPM by default rust-lang#91190
* Deduplicate projection sub-obligations rust-lang#90423
*  Sync portable-simd to remove autosplats rust-lang#91484 by dropping portable_simd entirely (keeping the subtree, just from std/core)
*  Quote bat script command line rust-lang#92208
* Fix failing tests rust-lang#92201 (CI fix)

r? `@Mark-Simulacrum`
@pnkfelix pnkfelix mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

None yet