Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] [1.57] Disable LLVM newPM by default #91189

Closed
wants to merge 1 commit into from
Closed

[beta] [1.57] Disable LLVM newPM by default #91189

wants to merge 1 commit into from

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Nov 24, 2021 •
edited

This is a temporary solution until we manage to get some sort of a workaround for the rampant inlining behaviour and other issues such as #91128 in place. Expect significant compilation time regressions in other areas, though.

@nagisa nagisa added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Nov 24, 2021
@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2021
@nagisa
Copy link
Member Author

nagisa commented Nov 24, 2021

I went ahead and unilaterally specified the beta-accepted tag based on conversation from here onwards.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid
Copy link
Member

camelid commented Nov 24, 2021

(Just noting it might be helpful to add some explanation of why this change is being made to the PR description.)

@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 24, 2021
@camelid
Copy link
Member

camelid commented Nov 24, 2021

Thanks for the description ❤️

Expect significant compilation time regressions in other areas, though.

@bors rollup=never

@camelid camelid added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Nov 24, 2021
@nagisa
Copy link
Member Author

nagisa commented Nov 24, 2021

One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the -Z flag to disable newPM, which I doubt they did.

@camelid
Copy link
Member

camelid commented Nov 24, 2021

I went ahead and unilaterally specified the beta-accepted tag based on conversation from here onwards.

This PR is filed against beta and marked as beta-accepted. Usually, one would just open a PR against master (#91190) and mark that as beta-accepted. Then someone from the release team will backport it.

@nikic
Copy link
Contributor

nikic commented Nov 24, 2021

One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the -Z flag to disable newPM, which I doubt they did.

I believe the LLVM 13 upgrade landed in 1.56 already, so it was tested in that release cycle. Though you're right that 1.57 did not receive any testing with the legacy PM.

@nagisa nagisa mentioned this pull request Nov 24, 2021
Closed
@Mark-Simulacrum Mark-Simulacrum changed the title [1.57] Disable LLVM newPM by default [beta] [1.57] Disable LLVM newPM by default Nov 26, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2021
@bors
Auto merge of rust-lang#91263 - Mark-Simulacrum:beta-next, r=Mark-Sim…
7e15b23 
…ulacrum

[beta] backports

* relate lifetime in TypeOutlives bounds on drop impls rust-lang#90840
*  [beta] [1.57] Disable LLVM newPM by default rust-lang#91189

r? `@Mark-Simulacrum`
@nikic
Copy link
Contributor

nikic commented Nov 28, 2021

This has been landed in #91263.

@nikic nikic closed this Nov 28, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnkfelix pnkfelix Awaiting requested review from pnkfelix

@nikic nikic Awaiting requested review from nikic

Assignees

@wesleywiser wesleywiser

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nagisa @rust-highfive @rust-log-analyzer @camelid @nikic @wesleywiser @Mark-Simulacrum