Constify (most) Option methods
#91928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
3 tasks
apiraino
added
the
T-libs
oli-obk
added
the
const-hack
fee1-dead
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
Ah. The bootstrap compiler does not yet have the param env fix. that is why this build is failing. |
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
fee1-dead
added
S-waiting-on-review
|
Please point the feature gates at the const trait impls tracking issue r=me with that |
fee1-dead
force-pushed
the
constification1
branch
from
805f357
to
f141bed
Compare
I made a library tracking issue and changed it to point at that instead. I feel like we shouldn't point library feature to the language feature tracking issue. @bors r=oli-obk |
|
📌 Commit f141bed has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 17, 2021
Constify (most) `Option` methods r? `@oli-obk`
This was referenced Dec 17, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#87901 (Fix suggestion of additional `pub` when using `pub pub fn ...`) - rust-lang#89090 (Lint bare traits in AstConv.) - rust-lang#91818 (Show the unused type for `unused_results` lint) - rust-lang#91910 (miri: lift restriction on extern types being the only field in a struct) - rust-lang#91928 (Constify (most) `Option` methods) - rust-lang#91975 (Move generator check earlier in inlining.) - rust-lang#92016 (builtin_macros: allow external consumers for AsmArgs parsing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk