Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #92059

Merged
merged 27 commits into from
Dec 18, 2021
Merged

Rollup of 7 pull requests #92059

merged 27 commits into from
Dec 18, 2021

Commits on Dec 4, 2021

  1. Configuration menu
    Copy the full SHA
    646f58a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95fb9ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6152b1d View commit details
    Browse the repository at this point in the history
  4. Use multipart suggestions.

    cjgillot committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    d3a6d4b View commit details
    Browse the repository at this point in the history
  5. Bless tests.

    cjgillot committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    748e95b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Configuration menu
    Copy the full SHA
    6fcbc3a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. Show the unused type for unused_results lint

    I think it's helpful to know what type was unused when looking at these
    warnings. The type will likely determine whether the result *should* be
    used, or whether it should just be ignored.
    
    Including the type also matches the behavior of the `must_use` lint:
    unused `SomeType` that must be used.
    camelid committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    f53e489 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Configuration menu
    Copy the full SHA
    b88a612 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cf96e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7bc8577 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5c99500 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0806b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    be33ca7 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Configuration menu
    Copy the full SHA
    d48dbdc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd47d24 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Configuration menu
    Copy the full SHA
    78a8e00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b5f63c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f555de View commit details
    Browse the repository at this point in the history
  4. Bless ui tests

    fee1-dead committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    493cf0c View commit details
    Browse the repository at this point in the history
  5. Point to the tracking issue

    fee1-dead committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f141bed View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Rollup merge of rust-lang#87901 - poliorcetics:pub-pub-pub, r=jackh726

    Fix suggestion of additional `pub` when using `pub pub fn ...`
    
    Fix rust-lang#87694.
    
    Marked as draft to start with because I want to explore doing the same fix for `const const fn` and other repeated-but-valid keywords.
    
    `@rustbot` label A-diagnostics D-invalid-suggestion T-compiler
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    54e7946 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#89090 - cjgillot:bare-dyn, r=jackh726

    Lint bare traits in AstConv.
    
    Removing the lint from lowering allows to:
    - make lowering querification easier;
    - have the lint implementation in only one place.
    
    r? `@estebank`
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    7a626cf View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#91818 - camelid:unused-result-type, r=jackh726

    Show the unused type for `unused_results` lint
    
    I think it's helpful to know what type was unused when looking at these
    warnings. The type will likely determine whether the result *should* be
    used, or whether it should just be ignored.
    
    Including the type also matches the behavior of the `must_use` lint:
    unused `SomeType` that must be used.
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    24b75e7 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#91910 - tmiasko:miri-extern-type, r=RalfJung

    miri: lift restriction on extern types being the only field in a struct
    
    Fixes rust-lang#91827.
    
    r? ````@RalfJung````
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    64ce698 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#91928 - fee1-dead:constification1, r=oli-obk

    Constify (most) `Option` methods
    
    r? ``@oli-obk``
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    fcc5979 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#91975 - cjgillot:noinline-generator, r=jack…

    …h726
    
    Move generator check earlier in inlining.
    
    Inlining into generator may create references to other generators. For instance, inlining `Pin::<&mut from_generator::GenFuture<[generator1]>>::new_unchecked` into `generator2`. This cross reference can then create cycles when computing inlining for `generator1`.
    
    In order to avoid this kind of surprises, we forbid all inlining into generators, and rely on LLVM to do the right thing. The existing `remove-zst-query-cycle` already ICEs in inline-mir mode, so we use it as test.
    
    Split from rust-lang#91743.
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    816cda7 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#92016 - calebcartwright:expose-asm-args-par…

    …sing, r=Amanieu
    
    builtin_macros: allow external consumers for AsmArgs parsing
    
    As discussed in Zulip (https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/parsing.20of.20AsmArgs.20for.20inline.20assembly), we need a function entry point that rustfmt can leverage from a pre-expansion context to get a more structured representation of the asm args without having to duplicate/maintain the token stream parsing
    
    r? ```@Amanieu``` and/or ```@joshtriplett```
    matthiaskrgr authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    fd445dd View commit details
    Browse the repository at this point in the history