Win32 fixes #9211
Closed
Win32 fixes #9211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable blocked tests which are now fixed by rust-lang#9165. Closes rust-lang#8810.
src/libstd/rt/io/support.rs
Outdated
There was a problem hiding this comment.
Could you use if cfg!(unix) {...} else {...} here instead? Seems to flow a bit nicer.
Assumes drive C: exists. Closes rust-lang#8812.
FormatMessageA may return non-ascii message, which is encoded as system code page, not utf8. This may cause `assert!(is_utf8(v))` failure on some non-English machines. This patch replaces it with FormatMessageW, which returns utf-16 message. Fixes `make check-stage2-std` failure on my machine. :)
Also enables request_sanity_check() test. Closes rust-lang#8817
|
rebased! |
Fixes `connect_error` part of rust-lang#8811.
They were blocked by rust-lang#8810, but it works now.
|
A failure in rustpkg seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.