Generate more precise generator names #92873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Currently all generators are named with a `generator$N` suffix, regardless of where they come from. This means an `async fn` shows up as a generator in stack traces, which can be surprising to async programmers since they should not need to know that async functions are implementated using generators. This change generators a different name depending on the generator kind, allowing us to tell whether the generator is the result of an async block, an async closure, an async fn, or a plain generator.
eholk
force-pushed
the
async-symbol-names
branch
from
3a363ff to
05e1f0d
Compare
This comment has been minimized.
This comment has been minimized.
|
Much better, thank you! @bors r+ |
|
📌 Commit a1173cf has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92747 (Simplification of BigNum::bit_length) - rust-lang#92767 (Use the new language identifier for Rust in the PDB debug format) - rust-lang#92775 (Inline std::os::unix::ffi::OsStringExt methods) - rust-lang#92863 (Remove `&mut` from `io::read_to_string` signature) - rust-lang#92865 (Ignore static lifetimes for GATs outlives lint) - rust-lang#92873 (Generate more precise generator names) - rust-lang#92879 (Add Sync bound to allocator parameter in vec::IntoIter) - rust-lang#92892 (Do not fail evaluation in const blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all generators are named with a
generator$Nsuffix, regardless of where they come from. This means anasync fnshows up as a generator in stack traces, which can be surprising to async programmers since they should not need to know that async functions are implementated using generators.This change generators a different name depending on the generator kind, allowing us to tell whether the generator is the result of an async block, an async closure, an async fn, or a plain generator.
r? @tmandry
cc @michaelwoerister @wesleywiser @dpaoliello