Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trait A: ~const B #93429

Merged
merged 4 commits into from
Jul 24, 2022
Merged

Allow trait A: ~const B #93429

merged 4 commits into from
Jul 24, 2022

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jan 28, 2022 •
edited
Loading

What's included: a minimal working change set for ~const supertraits to work.

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@fee1-dead fee1-dead mentioned this pull request Jan 28, 2022
Closed
@fee1-dead
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2022
@bors
Copy link
Contributor

bors commented Jan 29, 2022

⌛ Trying commit f4f7e399acdf9bb1afca576813ee9df908905c71 with merge 72e8656aa863887169592704ae8dec6b8830d2d3...

@bors
Copy link
Contributor

bors commented Jan 29, 2022

☀️ Try build successful - checks-actions
Build commit: 72e8656aa863887169592704ae8dec6b8830d2d3 (72e8656aa863887169592704ae8dec6b8830d2d3)

@rust-timer
Copy link
Collaborator

Queued 72e8656aa863887169592704ae8dec6b8830d2d3 with parent 24ae996, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (72e8656aa863887169592704ae8dec6b8830d2d3): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2022
@fee1-dead fee1-dead added the const-hack This PR introduced a hack to make things valid in `const fn`. label Feb 16, 2022
@oli-obk oli-obk added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Mar 2, 2022
@fee1-dead fee1-dead force-pushed the allow-super-trait-tilde-const branch from f4f7e39 to 6715c6f Compare July 23, 2022 14:26
@fee1-dead fee1-dead marked this pull request as ready for review July 23, 2022 14:32
@fee1-dead fee1-dead changed the title [WIP] Allow trait A: ~const B Allow trait A: ~const B Jul 23, 2022
@fee1-dead fee1-dead removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. const-hack This PR introduced a hack to make things valid in `const fn`. labels Jul 23, 2022
@fee1-dead
Copy link
Member Author

fee1-dead commented Jul 23, 2022 •
edited
Loading

@bors try @rust-timer queue

@bors
Copy link
Contributor

bors commented Jul 23, 2022

⌛ Trying commit 6715c6f00a03e9ccee5e7d51e80225cb4eaa66f4 with merge 37c82a23e1cc44e9a141a3281f6c91f25eec6d8a...

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 23, 2022
@bors
Copy link
Contributor

bors commented Jul 23, 2022

☀️ Try build successful - checks-actions
Build commit: 37c82a23e1cc44e9a141a3281f6c91f25eec6d8a (37c82a23e1cc44e9a141a3281f6c91f25eec6d8a)

@rust-timer
Copy link
Collaborator

Queued 37c82a23e1cc44e9a141a3281f6c91f25eec6d8a with parent 2e43d06, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (37c82a23e1cc44e9a141a3281f6c91f25eec6d8a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -4.6% -4.6% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -4.6% -4.6% 1

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.9% -3.9% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 23, 2022
@fee1-dead
Copy link
Member Author

@oli-obk is this okay to merge now?

@fee1-dead fee1-dead force-pushed the allow-super-trait-tilde-const branch from 6715c6f to 6660227 Compare July 24, 2022 07:57
@oli-obk
Copy link
Contributor

oli-obk commented Jul 24, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit 6660227 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022
@bors
Copy link
Contributor

bors commented Jul 24, 2022

⌛ Testing commit 6660227 with merge b4151a4...

@bors
Copy link
Contributor

bors commented Jul 24, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing b4151a4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2022
@bors bors merged commit b4151a4 into rust-lang:master Jul 24, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 24, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b4151a4): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.2% -1.2% 1
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.8% -2.8% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.8% -2.8% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.5% -2.9% 2
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.5% -2.9% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

yvt added a commit to r3-os/r3 that referenced this pull request Aug 13, 2022
@yvt
feat(core): use ~const in supertraits
afc66ce 
`[ref:const_supertraits]` has been resolved by [rust-lang/rust#93429][1].

[1]: rust-lang/rust#93429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fee1-dead @rust-timer @bors @oli-obk @rust-highfive @rustbot