Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tier-2 (without host tools) apple targets to separate builder #93434

Merged
merged 1 commit into from Jan 29, 2022

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jan 28, 2022

One-off (likely fairly unreliable, but give some idea) measurements:

  • dist-apple-various (new): 2h10m
  • dist-x86_64-apple: 2h55m -> 2h36m (cutting roughly 20 minutes)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@Mark-Simulacrum

This comment has been minimized.

@bors

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 28, 2022

☀️ Try build successful - checks-actions
Build commit: e44ea7de1cd5f0d621aa3305d2eeb8697a9d4f4c (e44ea7de1cd5f0d621aa3305d2eeb8697a9d4f4c)

@Mark-Simulacrum
Copy link
Member Author

r? @pietroalbini

@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2022

📌 Commit b726f28 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors rollup p=1 since we expect this to speed up CI times

@bors
Copy link
Contributor

bors commented Jan 29, 2022

⌛ Testing commit b726f28 with merge 24ae996...

@bors
Copy link
Contributor

bors commented Jan 29, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 24ae996 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2022
@bors bors merged commit 24ae996 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (24ae996): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Mark-Simulacrum Mark-Simulacrum deleted the apple-various branch January 31, 2022 22:30
@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Jan 31, 2022

Initial results look pretty promising on the dist-x86_64-apple builder:

image

Looks like the x86_64-apple builder is probably the next priority, and I expect some amount of further decrease as the median firms up at a lower boundary in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants