Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracking issue for const_fn_trait_bound #93682

Conversation

PatchMixolydic
Copy link
Contributor

@PatchMixolydic PatchMixolydic commented Feb 5, 2022

It previously pointed to #57563, the conglomerate issue for const fn (presumably under the feature gate const_fn). This tracking issue doesn't mention anything about const_fn_trait_bound(the only occurrence of "trait bound" is for the now-removed ?const Trait syntax), which can be confusing to people who want to find out more about trait bounds on const fns. This pull request changes the tracking issue to one meant specifically for const_fn_trait_bound, #93706, which can help collect information on this feature's stabilization and point users towards const_trait_impl if they're looking for const-in-const-contexts trait bounds.

Fixes #93679.

@rustbot modify labels +A-const-fn +F-const_trait_impl

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 5, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. F-const_trait_impl `#![feature(const_trait_impl)]` labels Feb 5, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2022
@PatchMixolydic PatchMixolydic marked this pull request as draft February 5, 2022 22:05
@PatchMixolydic PatchMixolydic marked this pull request as ready for review February 5, 2022 22:08
@PatchMixolydic

This comment was marked as outdated.

@PatchMixolydic PatchMixolydic changed the title Fix tracking issue for const_fn_trait_bound Update tracking issue for const_fn_trait_bound Feb 5, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 6, 2022

This feature is orthogonal to ~const on purpose and I would like to stabilize it soon without ~const. I think we should either give it its own tracking issue or just wait until we remove the feature .

@PatchMixolydic
Copy link
Contributor Author

PatchMixolydic commented Feb 6, 2022

Sorry about that; I might've jumped to conclusions a bit too quickly 😅. I've created a tracking issue for const_fn_trait_bound at #93706 and will update this PR shortly.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2022
It previously pointed to rust-lang#57563, the conglomerate issue for
`const fn` (presumably under the feature gate `const_fn`).
`const_fn_trait_bounds` weren't mentioned here, so this commit changes
its tracking issue to a new one.
@PatchMixolydic PatchMixolydic force-pushed the where-in-the-world-is-const_fn_trait_bound branch from d10a990 to 57b102f Compare February 6, 2022 16:44
@PatchMixolydic
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 6, 2022

Superb, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 6, 2022

📌 Commit 57b102f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 6, 2022
…s-const_fn_trait_bound, r=oli-obk

Update tracking issue for `const_fn_trait_bound`

It previously pointed to rust-lang#57563, the conglomerate issue for `const fn` (presumably under the feature gate `const_fn`). This tracking issue doesn't mention anything about `const_fn_trait_bound`(the only occurrence of "trait bound" is for the now-removed `?const Trait` syntax), which can be confusing to people who want to find out more about trait bounds on `const fn`s. This pull request changes the tracking issue to one meant specifically for `const_fn_trait_bound`, rust-lang#93706, which can help collect information on this feature's stabilization and point users towards `const_trait_impl` if they're looking for const-in-const-contexts trait bounds.

Fixes rust-lang#93679.

`@rustbot` modify labels +A-const-fn +F-const_trait_impl
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2022
…s-const_fn_trait_bound, r=oli-obk

Update tracking issue for `const_fn_trait_bound`

It previously pointed to rust-lang#57563, the conglomerate issue for `const fn` (presumably under the feature gate `const_fn`). This tracking issue doesn't mention anything about `const_fn_trait_bound`(the only occurrence of "trait bound" is for the now-removed `?const Trait` syntax), which can be confusing to people who want to find out more about trait bounds on `const fn`s. This pull request changes the tracking issue to one meant specifically for `const_fn_trait_bound`, rust-lang#93706, which can help collect information on this feature's stabilization and point users towards `const_trait_impl` if they're looking for const-in-const-contexts trait bounds.

Fixes rust-lang#93679.

``@rustbot`` modify labels +A-const-fn +F-const_trait_impl
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2022
…s-const_fn_trait_bound, r=oli-obk

Update tracking issue for `const_fn_trait_bound`

It previously pointed to rust-lang#57563, the conglomerate issue for `const fn` (presumably under the feature gate `const_fn`). This tracking issue doesn't mention anything about `const_fn_trait_bound`(the only occurrence of "trait bound" is for the now-removed `?const Trait` syntax), which can be confusing to people who want to find out more about trait bounds on `const fn`s. This pull request changes the tracking issue to one meant specifically for `const_fn_trait_bound`, rust-lang#93706, which can help collect information on this feature's stabilization and point users towards `const_trait_impl` if they're looking for const-in-const-contexts trait bounds.

Fixes rust-lang#93679.

```@rustbot``` modify labels +A-const-fn +F-const_trait_impl
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 7, 2022
…s-const_fn_trait_bound, r=oli-obk

Update tracking issue for `const_fn_trait_bound`

It previously pointed to rust-lang#57563, the conglomerate issue for `const fn` (presumably under the feature gate `const_fn`). This tracking issue doesn't mention anything about `const_fn_trait_bound`(the only occurrence of "trait bound" is for the now-removed `?const Trait` syntax), which can be confusing to people who want to find out more about trait bounds on `const fn`s. This pull request changes the tracking issue to one meant specifically for `const_fn_trait_bound`, rust-lang#93706, which can help collect information on this feature's stabilization and point users towards `const_trait_impl` if they're looking for const-in-const-contexts trait bounds.

Fixes rust-lang#93679.

````@rustbot```` modify labels +A-const-fn +F-const_trait_impl
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2022
Rollup of 13 pull requests

Successful merges:

 - rust-lang#88313 (Make the pre-commit script pre-push instead)
 - rust-lang#91530 (Suggest 1-tuple parentheses on exprs without existing parens)
 - rust-lang#92724 (Cleanup c_str.rs)
 - rust-lang#93208 (Impl {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}Assign<$t> for Wrapping<$t> for rust 1.60.0)
 - rust-lang#93394 (Don't allow {} to refer to implicit captures in format_args.)
 - rust-lang#93416 (remove `allow_fail` test flag)
 - rust-lang#93487 (Fix linking stage1 toolchain in `./x.py setup`)
 - rust-lang#93673 (Linkify sidebar headings for sibling items)
 - rust-lang#93680 (Drop json::from_reader)
 - rust-lang#93682 (Update tracking issue for `const_fn_trait_bound`)
 - rust-lang#93722 (Use shallow clones for submodules managed by rustbuild, not just bootstrap.py)
 - rust-lang#93723 (Rerun bootstrap's build script when RUSTC changes)
 - rust-lang#93737 (bootstrap: prefer using '--config' over 'RUST_BOOTSTRAP_CONFIG')

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4377a8 into rust-lang:master Feb 7, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 7, 2022
@PatchMixolydic PatchMixolydic deleted the where-in-the-world-is-const_fn_trait_bound branch February 8, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. F-const_trait_impl `#![feature(const_trait_impl)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where's the tracking issue for const_fn_trait_bound stabilization?
5 participants