Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #93795

Merged
merged 20 commits into from
Feb 9, 2022
Merged

Rollup of 7 pull requests #93795

merged 20 commits into from
Feb 9, 2022

Commits on Feb 3, 2022

  1. Configuration menu
    Copy the full SHA
    710662c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. Add From<u8> for ExitCode

    This should cover a mostly cross-platform subset of supported exit codes.
    yaahc authored and dtolnay committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    cf4ac6b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Configuration menu
    Copy the full SHA
    7d91d42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    687d20a View commit details
    Browse the repository at this point in the history
  3. 15221 -> 14956 exports

    klensy committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    7a75ebe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2918584 View commit details
    Browse the repository at this point in the history
  5. fix exclusive range error

    yaahc committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4c5a36e View commit details
    Browse the repository at this point in the history
  6. 14956 -> 14952 exports

    klensy committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    eb3b29f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Drop tracking: track borrows of projections

    Previous efforts to ignore partially consumed values meant we were also
    not considering borrows of a projection. This led to cases where we'd
    miss borrowed types which MIR expected to be there, leading to ICEs.
    eholk committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    97b24f3 View commit details
    Browse the repository at this point in the history
  2. rustdoc: tweak line and ¶ spacing for a11y

    The W3C Web Content Accessibility Guidelines specify a minimum line
    spacing of 1.5 and a minimum paragraph spacing of 1.5 times the line
    spacing. Our current line spacing (implemented by line-height) is 1.4,
    so it's a small bump to go up to 1.5. Similarly, we have a paragraph
    spacing of 0.6em. Bump that to 0.75em (which is 1.5 times the 0.5em
    distance between lines).
    
    Also, fix all the font sizes so instead of being round-ish numbers in
    rem (like 1.1rem, 1.2rem), they are round numbers in pixels. Ensure each
    font size is at least 2 pixels different than the nearest other font
    size, so distinctions can be clearly seen. Overall the font-sizes are
    mostly staying the same, being rounded up or down as appropriate.
    
    Remove a few unused styles.
    
    Simplify the display of the mobile-topbar location, by setting its
    margins to auto rather than trying to size it exactly to the topbar.
    jsha committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    dd5ff42 View commit details
    Browse the repository at this point in the history
  3. update ty::TyKind documentation

    lcnr committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    4c79353 View commit details
    Browse the repository at this point in the history
  4. Update compiler/rustc_middle/src/ty/sty.rs

    Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
    lcnr and oli-obk committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    af77bdf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a8be000 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Rollup merge of rust-lang#93445 - yaahc:exitcode-constructor, r=dtolnay

    Add From<u8> for ExitCode
    
    This should cover a mostly cross-platform subset of supported exit codes.
    
    We decided to stick with `u8` initially since its the common subset between all platforms that we support (excluding wasm which I think only works with `true` or `false`). Posix is supposed to take i32s, but in practice many unix platforms mask out all but the low 8 bits or in some cases the 8-15th bits. Windows takes a u32 instead of an i32. Bourne-compatible shells also report signals as exitcode 128 + `signal_no`, so there's some ambiguity there when returning exit codes > 127, but it is possible to disambiguate them on the other side so we decided against restricting the possible codes further than to `u8`.
    
    ## Related
    
    - Detailed analysis of exit code support on various platforms: https://internals.rust-lang.org/t/mini-pre-rfc-redesigning-process-exitstatus/5426
    - rust-lang#48711
    - rust-lang#43301
    - https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Termination.2FExit.20Status.20Stabilization
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ec2fd8a View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#93694 - jsha:font-sizes-spacing, r=Guillaum…

    …eGomez
    
    rustdoc: tweak line spacing and paragraph spacing for accessibility
    
    The [W3C Web Content Accessibility Guidelines](https://www.w3.org/WAI/WCAG21/Understanding/visual-presentation.html) specify a minimum line spacing of 1.5 and a minimum paragraph spacing of 1.5 times the line spacing. Our current line spacing (implemented by line-height) is 1.4, so it's a small bump to go up to 1.5. Similarly, we have a paragraph spacing of 0.6em. Bump that to 0.75em (which is 1.5 times the 0.5em distance between lines).
    
    Also, fix all the font sizes so instead of being round-ish numbers in rem (like 1.1rem, 1.2rem), they are round numbers in pixels: 16px, 18px, 20px, 22px, 24px. Ensure each font size is at least 2 pixels different than the nearest other font size, so distinctions can be clearly seen. Overall the font-sizes are mostly staying the same, being rounded up or down as appropriate. This will make reasoning about consistent layout sizes much easier.
    
    Remove a few unused styles.
    
    Simplify the display of the mobile-topbar location, by setting its margins to auto rather than trying to size it exactly to the topbar.
    
    Part of rust-lang#59845.
    
    Demo: https://rustdoc.crud.net/jsha/font-sizes-spacing/std/string/struct.String.html
    
    r? `@GuillaumeGomez`
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a508448 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#93735 - m-ou-se:stabilize-int-abs-diff, r=j…

    …oshtriplett
    
    Stabilize int_abs_diff in 1.60.0.
    
    FCP finished here: rust-lang#89492 (comment)
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    5609465 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#93746 - cjgillot:nodefii, r=nikomatsakis

    Remove defaultness from ImplItem.
    
    This information is not really used anywhere, except HIR pretty-printing. This makes ImplItem and TraitItem more similar.
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    e5ac087 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#93748 - klensy:vis-r, r=cjgillot

    rustc_query_impl: reduce visibility of some modules/fn's
    
    Locally this reduces number of exported functions from 15221 -> 14952 and size a little.
    
    Perf run please?
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    68fa9b1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#93751 - eholk:issue-93648-drop-tracking-pro…

    …jection, r=tmiasko
    
    Drop tracking: track borrows of projections
    
    Previous efforts to ignore partially consumed values meant we were also not considering borrows of a projection. This led to cases where we'd miss borrowed types which MIR expected to be there, leading to ICEs.
    
    This PR also includes the `-Zdrop-tracking` flag from rust-lang#93313. If that PR lands first, I'll rebase to drop the commit from this one.
    
    Fixes rust-lang#93648
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a07eed9 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#93781 - lcnr:ty-kind-docs, r=jackh726

    update `ty::TyKind` documentation
    
    slightly unsure about `ty::Opaque` and `ty::Bound`/`ty::Placeholder`.
    
    r? `@jackh726` `@nikomatsakis` `@oli-obk`
    JohnTitor committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    7f4486b View commit details
    Browse the repository at this point in the history