Prepare Rust for opaque pointers #94214

nikic · 2022-02-21T10:46:18Z

Fix one codegen bug with opaque pointers, and update our IR tests to accept both typed pointer and opaque pointer IR. This is a bit annoying, but unavoidable if we want decent test coverage on both LLVM 14 and LLVM 15.

This prepares Rust for when LLVM will enable opaque pointers by default.

nikic · 2022-02-21T10:47:04Z

@bors try @rust-timer queue

rust-timer · 2022-02-21T10:47:06Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-02-21T10:47:12Z

⌛ Trying commit 52196c92d12aa9221b27ee2e4276cd60ae9e387c with merge 3510be61bf5fddada12fcce24c6b7b1b1e3cc06a...

bors · 2022-02-21T12:45:55Z

☀️ Try build successful - checks-actions
Build commit: 3510be61bf5fddada12fcce24c6b7b1b1e3cc06a (3510be61bf5fddada12fcce24c6b7b1b1e3cc06a)

rust-timer · 2022-02-21T12:45:57Z

Queued 3510be61bf5fddada12fcce24c6b7b1b1e3cc06a with parent 026d8ce, future comparison URL.

rust-timer · 2022-02-21T14:16:00Z

Finished benchmarking commit (3510be61bf5fddada12fcce24c6b7b1b1e3cc06a): comparison url.

Summary: This benchmark run shows 149 relevant improvements 🎉 but 159 relevant regressions 😿 to instruction counts.

Average relevant regression: 0.9%
Average relevant improvement: -3.4%
Largest improvement in instruction counts: -61.4% on incr-patched: println builds of webrender-wrench opt
Largest regression in instruction counts: 4.4% on incr-patched: println builds of webrender opt

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

eddyb · 2022-02-23T13:27:33Z

@nikic Would it make sense to do another perf run with opaque pointers toggled off, but the same llvm-project submodule? To be able to compare across just "turning opaque pointers on" as opposed to any other changes to llvm-project potentially affecting the results.

EDIT: oh, wait, opaque pointers are coming entirely from the submodule switch? I guess in that case my idea would require adding a way to control it through FFI, sorry I missed that aspect at first.

eddyb · 2022-02-23T13:28:54Z

src/test/codegen/abi-main-signature-32bit-c-int.rs

@@ -7,4 +7,4 @@
 fn main() {
 }

-// CHECK: define i32 @main(i32{{( %0)?}}, i8**{{( %1)?}})
+// CHECK: define i32 @main(i32{{( %0)?}}, {{i8**|ptr}}{{( %1)?}})


This probably needs i8\*\* since it's inside a regex, right? (Similar thing in other files)

nikic · 2022-02-25T17:49:51Z

@bors try @rust-timer queue

rust-timer · 2022-02-25T17:49:52Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-02-25T17:49:59Z

⌛ Trying commit d27788cf1775f500a171d9a9d389408f6110b181 with merge 622e70f20deebb450e36b82cbabaa1a359e3b228...

bors · 2022-02-25T19:40:24Z

☀️ Try build successful - checks-actions
Build commit: 622e70f20deebb450e36b82cbabaa1a359e3b228 (622e70f20deebb450e36b82cbabaa1a359e3b228)

rust-timer · 2022-02-25T19:40:26Z

Queued 622e70f20deebb450e36b82cbabaa1a359e3b228 with parent 9f8f0a6, future comparison URL.

rust-timer · 2022-02-25T21:34:45Z

Finished benchmarking commit (622e70f20deebb450e36b82cbabaa1a359e3b228): comparison url.

Summary: This benchmark run shows 134 relevant improvements 🎉 but 163 relevant regressions 😿 to instruction counts.

Arithmetic mean of relevant regressions: 1.0%
Arithmetic mean of relevant improvements: -3.4%
Arithmetic mean of all relevant changes: -1.0%
Largest improvement in instruction counts: -21.2% on full builds of deep-vector opt
Largest regression in instruction counts: 5.6% on incr-patched: println builds of cargo opt

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

nikic · 2022-02-25T21:39:24Z

Testing baseline without opaque pointers now...

@bors try @rust-timer queue

rust-timer · 2022-02-25T21:39:25Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

nikic · 2022-05-25T16:04:06Z

r? @cuviper

cuviper

Whew, it will be a happy day when we can unify on ptr in all those tests...

cuviper · 2022-05-27T22:34:56Z

src/test/assembly/stack-protector/stack-protector-heuristics-effect.rs

@@ -78,7 +78,7 @@ pub fn array_u8_1(f: fn(*const u8)) {
 #[no_mangle]
 pub fn array_u8_small(f: fn(*const u8)) {
    let a = [0u8; 2];
-    let b = [0u8; 8];
+    let b = [0u8; 7];


Is this change somehow related to opaque pointers? Or is it something else incidental on llvm main? I don't see a problem with the change, but it seems curious.

This is intended to test a heuristic that does not place a stack protector for arrays (strictly) smaller than 8, so it should be using size 7. The test still worked previously, because the [8 x i8] alloca was converted into an i64 alloca, and did not receive the stack protector for that reason. This doesn't happen anymore with opaque pointers. The way these heuristics are currently implemented (inspecting alloca types in the backend) is unfortunately not stable under optimization (probably it should be a frontend responsibility to add metadata to allocas that should receive a protector, or something like that).

The documentation says that it is for any N > 8, not any N >= 8:

rust/compiler/rustc_codegen_llvm/src/lib.rs

Line 308 in ed76b77

- local variables of `[T; N]` type, where `T` is byte-sized and `N` > 8.

Yeah, the documentation is wrong as well. I'll fix it. For reference, the actual logic is here: https://github.com/llvm/llvm-project/blob/65af17c7a00df3f8906cded34b63b309e687cf61/llvm/lib/CodeGen/StackProtector.cpp#L134

A stack protector is used for N >= 8, not N > 8.

cuviper · 2022-05-28T23:02:42Z

@bors r+

bors · 2022-05-28T23:02:44Z

📌 Commit 1ff051a has been approved by cuviper

bors · 2022-05-29T02:59:55Z

⌛ Testing commit 1ff051a with merge 843c7e900179da05320dc6f7a4a1699dddaa592f...

rust-log-analyzer · 2022-05-29T03:14:09Z

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      System Firmware Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMN3juLYtsjH
      Provisioning UDID: 4203018E-580F-C1B5-9525-B745CECA79EB

hw.ncpu: 3
hw.byteorder: 1234

bors · 2022-05-29T03:15:18Z

💔 Test failed - checks-actions

nikic · 2022-05-29T13:46:42Z

@bors retry spurious network error

bors · 2022-05-29T14:12:45Z

⌛ Testing commit 1ff051a with merge 9d1aeae...

bors · 2022-05-29T16:28:13Z

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 9d1aeae to master...

rust-timer · 2022-05-29T17:46:22Z

Finished benchmarking commit (9d1aeae): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.0%	2.8%	4
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.3%	2.3%	1
Improvements 🎉 (primary)	-3.5%	-4.0%	3
Improvements 🎉 (secondary)	-2.7%	-2.7%	2
All 😿🎉 (primary)	-3.5%	-4.0%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

Pkgsrc changes: * Adjust patches as needed & checksum updates. Upstream changes: Version 1.63.0 (2022-08-11) ========================== Language -------- - [Remove migrate borrowck mode for pre-NLL errors.][95565] - [Modify MIR building to drop repeat expressions with length zero.][95953] - [Remove label/lifetime shadowing warnings.][96296] - [Allow explicit generic arguments in the presence of `impl Trait` args.] [96868] - [Make `cenum_impl_drop_cast` warnings deny-by-default.][97652] - [Prevent unwinding when `-C panic=abort` is used regardless of declared ABI.][96959] - [lub: don't bail out due to empty binders.][97867] Compiler -------- - [Stabilize the `bundle` native library modifier,][95818] also removing the deprecated `static-nobundle` linking kind. - [Add Apple WatchOS compile targets\*.][95243] - [Add a Windows application manifest to rustc-main.][96737] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Implement `Copy`, `Clone`, `PartialEq` and `Eq` for `core::fmt::Alignment`.][94530] - [Extend `ptr::null` and `null_mut` to all thin (including extern) types.][94954] - [`impl Read and Write for VecDeque<u8>`.][95632] - [STD support for the Nintendo 3DS.][95897] - [Make write/print macros eagerly drop temporaries.][96455] - [Implement internal traits that enable `[OsStr]::join`.][96881] - [Implement `Hash` for `core::alloc::Layout`.][97034] - [Add capacity documentation for `OsString`.][97202] - [Put a bound on collection misbehavior.][97316] - [Make `std::mem::needs_drop` accept `?Sized`.][97675] - [`impl Termination for Infallible` and then make the `Result` impls of `Termination` more generic.][97803] - [Document Rust's stance on `/proc/self/mem`.][97837] Stabilized APIs --------------- - [`array::from_fn`] - [`Box::into_pin`] - [`BinaryHeap::try_reserve`] - [`BinaryHeap::try_reserve_exact`] - [`OsString::try_reserve`] - [`OsString::try_reserve_exact`] - [`PathBuf::try_reserve`] - [`PathBuf::try_reserve_exact`] - [`Path::try_exists`] - [`Ref::filter_map`] - [`RefMut::filter_map`] - [`NonNull::<[T]>::len`][`NonNull::<slice>::len`] - [`ToOwned::clone_into`] - [`Ipv6Addr::to_ipv4_mapped`] - [`unix::io::AsFd`] - [`unix::io::BorrowedFd<'fd>`] - [`unix::io::OwnedFd`] - [`windows::io::AsHandle`] - [`windows::io::BorrowedHandle<'handle>`] - [`windows::io::OwnedHandle`] - [`windows::io::HandleOrInvalid`] - [`windows::io::HandleOrNull`] - [`windows::io::InvalidHandleError`] - [`windows::io::NullHandleError`] - [`windows::io::AsSocket`] - [`windows::io::BorrowedSocket<'handle>`] - [`windows::io::OwnedSocket`] - [`thread::scope`] - [`thread::Scope`] - [`thread::ScopedJoinHandle`] These APIs are now usable in const contexts: - [`array::from_ref`] - [`slice::from_ref`] - [`intrinsics::copy`] - [`intrinsics::copy_nonoverlapping`] - [`<*const T>::copy_to`] - [`<*const T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_to`] - [`<*mut T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_from`] - [`<*mut T>::copy_from_nonoverlapping`] - [`str::from_utf8`] - [`Utf8Error::error_len`] - [`Utf8Error::valid_up_to`] - [`Condvar::new`] - [`Mutex::new`] - [`RwLock::new`] Cargo ----- - [Stabilize the `--config path` command-line argument.][cargo/10755] - [Expose rust-version in the environment as `CARGO_PKG_RUST_VERSION`.][cargo/10713] Compatibility Notes ------------------- - [`#[link]` attributes are now checked more strictly,][96885] which may introduce errors for invalid attribute arguments that were previously ignored. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Prepare Rust for LLVM opaque pointers.][94214] [94214]: rust-lang/rust#94214 [94530]: rust-lang/rust#94530 [94954]: rust-lang/rust#94954 [95243]: rust-lang/rust#95243 [95565]: rust-lang/rust#95565 [95632]: rust-lang/rust#95632 [95818]: rust-lang/rust#95818 [95897]: rust-lang/rust#95897 [95953]: rust-lang/rust#95953 [96296]: rust-lang/rust#96296 [96455]: rust-lang/rust#96455 [96737]: rust-lang/rust#96737 [96868]: rust-lang/rust#96868 [96881]: rust-lang/rust#96881 [96885]: rust-lang/rust#96885 [96959]: rust-lang/rust#96959 [97034]: rust-lang/rust#97034 [97202]: rust-lang/rust#97202 [97316]: rust-lang/rust#97316 [97652]: rust-lang/rust#97652 [97675]: rust-lang/rust#97675 [97803]: rust-lang/rust#97803 [97837]: rust-lang/rust#97837 [97867]: rust-lang/rust#97867 [cargo/10713]: rust-lang/cargo#10713 [cargo/10755]: rust-lang/cargo#10755 [`array::from_fn`]: https://doc.rust-lang.org/stable/std/array/fn.from_fn.html [`Box::into_pin`]: https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_pin [`BinaryHeap::try_reserve_exact`]: https://doc.rust-lang.org/stable/alloc/collections/binary_heap/struct.BinaryHeap.html#method.try_reserve_exact [`BinaryHeap::try_reserve`]: https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html#method.try_reserve [`OsString::try_reserve`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve [`OsString::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve_exact [`PathBuf::try_reserve`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve [`PathBuf::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve_exact [`Path::try_exists`]: https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.try_exists [`Ref::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.Ref.html#method.filter_map [`RefMut::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.RefMut.html#method.filter_map [`NonNull::<slice>::len`]: https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.len [`ToOwned::clone_into`]: https://doc.rust-lang.org/stable/std/borrow/trait.ToOwned.html#method.clone_into [`Ipv6Addr::to_ipv4_mapped`]: https://doc.rust-lang.org/stable/std/net/struct.Ipv6Addr.html#method.to_ipv4_mapped [`unix::io::AsFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/trait.AsFd.html [`unix::io::BorrowedFd<'fd>`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.BorrowedFd.html [`unix::io::OwnedFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.OwnedFd.html [`windows::io::AsHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsHandle.html [`windows::io::BorrowedHandle<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedHandle.html [`windows::io::OwnedHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedHandle.html [`windows::io::HandleOrInvalid`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrInvalid.html [`windows::io::HandleOrNull`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrNull.html [`windows::io::InvalidHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.InvalidHandleError.html [`windows::io::NullHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.NullHandleError.html [`windows::io::AsSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsSocket.html [`windows::io::BorrowedSocket<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedSocket.html [`windows::io::OwnedSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedSocket.html [`thread::scope`]: https://doc.rust-lang.org/stable/std/thread/fn.scope.html [`thread::Scope`]: https://doc.rust-lang.org/stable/std/thread/struct.Scope.html [`thread::ScopedJoinHandle`]: https://doc.rust-lang.org/stable/std/thread/struct.ScopedJoinHandle.html [`array::from_ref`]: https://doc.rust-lang.org/stable/std/array/fn.from_ref.html [`slice::from_ref`]: https://doc.rust-lang.org/stable/std/slice/fn.from_ref.html [`intrinsics::copy`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy.html [`intrinsics::copy_nonoverlapping`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy_nonoverlapping.html [`<*const T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to [`<*const T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping [`<*mut T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to-1 [`<*mut T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping-1 [`<*mut T>::copy_from`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from [`<*mut T>::copy_from_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from_nonoverlapping [`str::from_utf8`]: https://doc.rust-lang.org/stable/std/str/fn.from_utf8.html [`Utf8Error::error_len`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.error_len [`Utf8Error::valid_up_to`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.valid_up_to [`Condvar::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html#method.new [`Mutex::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.new [`RwLock::new`]: https://doc.rust-lang.org/stable/std/sync/struct.RwLock.html#method.new

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 21, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2022

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 21, 2022

eddyb reviewed Feb 23, 2022

View reviewed changes

nikic force-pushed the rust-opaque-pointers branch from 52196c9 to d5dfac2 Compare February 25, 2022 17:10

This comment has been minimized.

Sign in to view

nikic force-pushed the rust-opaque-pointers branch 2 times, most recently from 8d6d821 to d27788c Compare February 25, 2022 17:46

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 25, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 25, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 25, 2022

rust-highfive assigned cuviper May 25, 2022

cuviper approved these changes May 27, 2022

View reviewed changes

Fix documentation of basic stack protector

1ff051a

A stack protector is used for N >= 8, not N > 8.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 29, 2022

bors merged commit 9d1aeae into rust-lang:master May 29, 2022

rustbot added this to the 1.63.0 milestone May 29, 2022

This was referenced May 29, 2022

Enable MIR inlining #91743

Merged

Remove dereferencing of Box from codegen #95576

Merged

rustbot removed the perf-regression Performance regression. label May 29, 2022

eddyb mentioned this pull request Jun 28, 2022

rustc_codegen_ssa: don't use LLVM struct types for field offsets. #98615

Closed

DieracDelta mentioned this pull request Aug 15, 2022

Revert to rust stable EspressoSystems/espresso#564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare Rust for opaque pointers #94214

Prepare Rust for opaque pointers #94214

nikic commented Feb 21, 2022 •

edited

nikic commented Feb 21, 2022

rust-timer commented Feb 21, 2022

bors commented Feb 21, 2022

bors commented Feb 21, 2022

rust-timer commented Feb 21, 2022

rust-timer commented Feb 21, 2022

eddyb commented Feb 23, 2022 •

edited

eddyb Feb 23, 2022

This comment has been minimized.

nikic commented Feb 25, 2022

rust-timer commented Feb 25, 2022

bors commented Feb 25, 2022

bors commented Feb 25, 2022

rust-timer commented Feb 25, 2022

rust-timer commented Feb 25, 2022

nikic commented Feb 25, 2022

rust-timer commented Feb 25, 2022

nikic commented May 25, 2022

cuviper left a comment

cuviper May 27, 2022

nikic May 28, 2022

bjorn3 May 28, 2022

nikic May 28, 2022

cuviper commented May 28, 2022

bors commented May 28, 2022

bors commented May 29, 2022

rust-log-analyzer commented May 29, 2022

bors commented May 29, 2022

nikic commented May 29, 2022

bors commented May 29, 2022

bors commented May 29, 2022

rust-timer commented May 29, 2022

Prepare Rust for opaque pointers #94214

Prepare Rust for opaque pointers #94214

Conversation

nikic commented Feb 21, 2022 • edited

nikic commented Feb 21, 2022

rust-timer commented Feb 21, 2022

bors commented Feb 21, 2022

bors commented Feb 21, 2022

rust-timer commented Feb 21, 2022

rust-timer commented Feb 21, 2022

eddyb commented Feb 23, 2022 • edited

Choose a reason for hiding this comment

This comment has been minimized.

nikic commented Feb 25, 2022

rust-timer commented Feb 25, 2022

bors commented Feb 25, 2022

bors commented Feb 25, 2022

rust-timer commented Feb 25, 2022

rust-timer commented Feb 25, 2022

nikic commented Feb 25, 2022

rust-timer commented Feb 25, 2022

nikic commented May 25, 2022

cuviper left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cuviper commented May 28, 2022

bors commented May 28, 2022

bors commented May 29, 2022

rust-log-analyzer commented May 29, 2022

bors commented May 29, 2022

nikic commented May 29, 2022

bors commented May 29, 2022

bors commented May 29, 2022

rust-timer commented May 29, 2022

Footnotes

nikic commented Feb 21, 2022 •

edited

eddyb commented Feb 23, 2022 •

edited