update const_generics_defaults release notes #94294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
idk if changing this directly on stable is correct |
|
No, we don't typically merge to stable unless we're actually meaningfully changing something (since that takes a full bors build cycle). If you can refile against master (and "back"port the release notes from stable), that would be good. There's a few issues noted in #94278 that might also be nice to patch up on the way. Unrelated to the contents of this PR, you probably don't want to be creating branches in rust-lang/rust (e.g., lcnr-patch-1). The GitHub UI unfortunately forces this if you edit on the frontend and have write access, but those branches are visible to everyone and are somewhat noisy as a result. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 25, 2022
update const_generics_defaults release notes supersedes rust-lang#94294 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably seems worth explicitly mentioning this, considering that for myself, that's actually the feature i care more about ^^