Skip to content

Conversation

alexcrichton
Copy link
Member

This fixes private statics and functions from being usable cross-crates, along
with some bad privacy error messages. This is a reopening of #8365 with all the
privacy checks in privacy.rs instead of resolve.rs (where they should be
anyway).

These maps of exported items will hopefully get used for generating
documentation by rustdoc

Closes #8592

@alexcrichton
Copy link
Member Author

The major point of this pull request is to actually enforce visibility across crates. Previously everything was public, this corrects this to the idea of "a destination is public if everything leading to it is public".

This fixes private statics and functions from being usable cross-crates, along
with some bad privacy error messages. This is a reopening of rust-lang#8365 with all the
privacy checks in privacy.rs instead of resolve.rs (where they should be
anyway).

These maps of exported items will hopefully get used for generating
documentation by rustdoc

Closes rust-lang#8592
This is required by the check-fast target because each test is slurped up into a
submodule.
bors added a commit that referenced this pull request Sep 25, 2013
…walton

This fixes private statics and functions from being usable cross-crates, along
with some bad privacy error messages. This is a reopening of #8365 with all the
privacy checks in privacy.rs instead of resolve.rs (where they should be
anyway).

These maps of exported items will hopefully get used for generating
documentation by rustdoc

Closes #8592
@bors bors closed this Sep 25, 2013
@bors bors merged commit 30862a6 into rust-lang:master Sep 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing/incorrect error messages with respect to visibility and traits
3 participants