Skip to content

Conversation

RalfJung
Copy link
Member

Roughly follows the codegen logic.

Fixes rust-lang/miri#1038
r? @oli-obk Cc @eddyb

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 18, 2022
@rust-highfive
Copy link
Contributor

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 20, 2022

Bot codegen and this logic seem fishy and I think we should do something better, but I don't know what yet.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 20, 2022

📌 Commit fa5fa72 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022
@bors
Copy link
Collaborator

bors commented Mar 20, 2022

⌛ Testing commit fa5fa72 with merge 9bd5371...

@bors
Copy link
Collaborator

bors commented Mar 20, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9bd5371 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2022
@bors bors merged commit 9bd5371 into rust-lang:master Mar 20, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 20, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9bd5371): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

bors added a commit to rust-lang/miri that referenced this pull request Mar 20, 2022
@RalfJung RalfJung deleted the arbitrary-self-dyn branch March 20, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement arbitrary-self dynamic method receivers
6 participants