diagnostics: do not give Option::as_ref suggestion for complex match

[notriddle]

Fixes #82528

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[estebank]

I'm guessing it'd be difficult to find the correct span to suggest .as_ref() inside the tuple? It might also be reasonable to mention .as_ref() in a note instead.

@bors r+

[bors]

📌 Commit 306dcd6 has been approved by estebank

[notriddle]

I'm guessing it'd be difficult to find the correct span to suggest .as_ref() inside the tuple?

Basically, there might not be a correct span.

I would have needed to go back to the THIR and walked the expr tree looking for it, with no guarantee of finding it, so no matter what happens we’ll need a fallback path eventually.

match me() {
    (a, Some(b)) => use(a, b)
}
fn me() -> (Foo, &Option<Bar>) { … }
fn use(a: Foo, b: &Bar) { … }

[bors]

⌛ Testing commit 306dcd6 with merge 2d15732...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2d15732 to master...

[rust-timer]

Finished benchmarking commit (2d15732): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression