Update Clippy #95273
Merged
Update Clippy #95273
+1,957
−546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some, r=camsteffen Make `search_is_some`s suggestion `MachineApplicable` My biggest PR to date, about 0.3 Lines have been changed! Closes rust-lang/rust-clippy#8062 The suggestion seems to work well, as we've received no error reports since the implementation in December. This PR therefore promotes the suggestion to `MachineApplicable`. The tests already include `.fixed` files :) changelog: [`search_is_some`]: Make more suggestions `MachineApplicable`
…ports-for-macros, r=llogiq Allow `single_component_path_imports` for all macros Closes: rust-lang/rust-clippy#7923 It can be useful to have `use macro_name` regardless of the visibility. This removes the visibility filter. changelog: [`single_component_path_imports`]: no longer triggers on macros
Fix `unncessary_to_owned` false positive Fix rust-lang#8507 changelog: none
…giraffate Move iter_with_drain to nursery cc rust-lang#8538 rust-lang#8539 r? `@giraffate` changelog: Move [`iter_with_drain`] to nursery
[`collapsible_if`] fix typo in code-block kind specifier *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`collapsible_if`] fix typo in code-block kind specifier
More `transmute_undefined_repr` fixes fixes: rust-lang#8498 fixes: rust-lang#8501 fixes: rust-lang#8503 changelog: Allow `transumte_undefined_repr` between fat pointers and `(usize, usize)` changelog: Allow `transumte_undefined_repr` when one side is a union changelog: Fix `transumte_undefined_repr` on tuples with one non-zero-sized type.
Moved ``[try_err]`` to restriction Fixes rust-lang#5757 changelog: Moved try_err lint to rescrition for rust-lang#5757
Signed-off-by: codehorseman <cricis@yeah.net>
…in `match_same_arm`
add new function `span_lint_and_sugg_` for edges in `clippy_utils::diagnostics`
fix suggestion on `[map_flatten]` being cropped causing possible information loss fixes rust-lang#8506 Multi-line suggestion given by the lint is missing its bottom part, which could potentially contains useful information about the fix. --- changelog: [`map_flatten`]: Long suggestions will now be splitup into two help messages
add `or_then_unwrap` Closes rust-lang#8557 changelog: New lint [`or_then_unwrap`]
`match_same_arms` fix fixes rust-lang#860 fixes rust-lang#1140 changelog: Don't lint `match_same_arms` when an interposing arm's pattern would overlap
`unnecessary_join` lint
changelog: Adds a lint called ``[`unnecessary_join`]`` that detects cases of `.collect::<Vec<String>>.join("")` or `.collect::<Vec<_>>.join("")` on an iterator, suggesting `.collect::<String>()` instead
Fixes: rust-lang/rust-clippy#8570
This is a reopen of rust-lang/rust-clippy#8573
changelog: add lint [`unnecessary_join`]
Rustup r? `@ghost` Nice small sync with only typo fixes changelog: none
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=2 rollup=never |
|
@bors r=manishearth rollup=never p=2 |
|
📌 Commit 3365e9a has been approved by |
bors
added
S-waiting-on-bors
|
@bors r=manishearth rollup=never p=2 |
|
📌 Commit 3365e9a has been approved by |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (7941b3f): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 7, 2022
Update Clippy r? `@Manishearth`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth