Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hermitkernel targets #95299

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Conversation

mkroening
Copy link
Contributor

@mkroening mkroening commented Mar 25, 2022

RustyHermit now maintains custom json targets, which are distributed with the kernel: hermit-os/kernel#395

See hermit-os/hermit-rs#197 (comment)
CC: @stlankes, @bstrie

RustyHermit now maintains custom json targets, which are distributed with the kernel. [1]

[1]: hermit-os/kernel#395
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 25, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2022
@joshtriplett
Copy link
Member

Hopefully Hermit will be able to use x86_64-unknown-none when it's available; in the meantime, thank you for helping us clean up our target list.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 25, 2022

📌 Commit 335d196 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 26, 2022
…iplett

Remove hermitkernel targets

RustyHermit now maintains custom json targets, which are distributed with the kernel: hermit-os/kernel#395

See hermit-os/hermit-rs#197 (comment)
CC: `@stlankes,` `@bstrie`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 26, 2022
…iplett

Remove hermitkernel targets

RustyHermit now maintains custom json targets, which are distributed with the kernel: hermit-os/kernel#395

See hermit-os/hermit-rs#197 (comment)
CC: ``@stlankes,`` ``@bstrie``
@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Testing commit 335d196 with merge d4acac9...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing d4acac9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 26, 2022
@bors bors merged commit d4acac9 into rust-lang:master Mar 26, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 26, 2022
@mkroening mkroening deleted the rm-hermitkernel branch March 26, 2022 18:37
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d4acac9): comparison url.

Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 13, 2022
Fix platform support links.

Hermitkernel was removed in rust-lang#95299.  nvptx was added in rust-lang#95896 without being added to the SUMMARY.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants