Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 27, 2022

Before:

failures:
    [ui] rustdoc-ui/intra-doc/feature-gate-intra-doc-pointers.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 163 filtered out; finished in 0.45s

After:

failures:
    [ui] src/test/rustdoc-ui/intra-doc/feature-gate-intra-doc-pointers.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 163 filtered out; finished in 0.45s

This allows copy pasting the path or using Ctrl+Click in IDEs to go directly to the file, instead of having to edit the filename first.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2022
@jyn514 jyn514 changed the title Print the full relative path to failed tests [bootstrap] Print the full relative path to failed tests Mar 27, 2022
Before:
```
failures:
    [ui] rustdoc-ui/intra-doc/feature-gate-intra-doc-pointers.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 163 filtered out; finished in 0.45s
```

After:
```
failures:
    [ui] src/test/rustdoc-ui/intra-doc/feature-gate-intra-doc-pointers.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 163 filtered out; finished in 0.45s
```

This allows copy pasting the path or using Ctrl+Click in IDEs to go directly to the file, instead of having to edit the filename first.
@jyn514 jyn514 force-pushed the full-relative-path branch from 2911bb6 to d0a3260 Compare March 27, 2022 04:14
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 6, 2022

📌 Commit d0a3260 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022
@bors
Copy link
Collaborator

bors commented Apr 6, 2022

⌛ Testing commit d0a3260 with merge 6a45608efd497b3890f5b77924e955b16bcfb2f1...

@bors
Copy link
Collaborator

bors commented Apr 6, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 6, 2022
@jyn514
Copy link
Member Author

jyn514 commented Apr 6, 2022

Failure looks spurious?

2022-04-06T21:14:17.6222472Z failures:
2022-04-06T21:14:17.6222626Z 
2022-04-06T21:14:17.6222851Z ---- [ui] src/test\ui-fulldeps\stdio-from.rs stdout ----
2022-04-06T21:14:17.6223412Z Some tests failed in compiletest suite=ui-fulldeps mode=ui host=i686-pc-windows-msvc target=i686-pc-windows-msvc
2022-04-06T21:14:17.6225391Z 
2022-04-06T21:14:17.6225721Z error: test run failed!
2022-04-06T21:14:17.6226299Z status: exit code: 101
2022-04-06T21:14:17.6233986Z command: PATH="D:\a\rust\rust\build\i686-pc-windows-msvc\stage2\lib\rustlib\i686-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x86;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw32\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.3\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.322-6\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\ui-fulldeps\\stdio-from\\a.exe"
2022-04-06T21:14:17.6241631Z stdout: none
2022-04-06T21:14:17.6241933Z --- stderr -------------------------------
2022-04-06T21:14:17.6242533Z I/O error: operation failed to complete synchronously
2022-04-06T21:14:17.6243434Z thread 'main' panicked at 'assertion failed: child2.wait()?.success()', D:\a\rust\rust\src/test\ui-fulldeps\stdio-from.rs:50:5
2022-04-06T21:14:17.6244187Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2022-04-06T21:14:17.6244742Z ------------------------------------------
2022-04-06T21:14:17.6244954Z 
2022-04-06T21:14:17.6244960Z 
2022-04-06T21:14:17.6244965Z 
2022-04-06T21:14:17.6245067Z failures:
2022-04-06T21:14:17.6245385Z     [ui] src/test\ui-fulldeps\stdio-from.rs
2022-04-06T21:14:17.6245600Z 
2022-04-06T21:14:17.6245865Z test result: FAILED. 65 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 26.37s

@klensy
Copy link
Contributor

klensy commented Apr 6, 2022

Error message from less than one day merged #95469, so maybe not spurious.

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] Rustc { target: TargetSelection { triple: "i686-pc-windows-msvc", file: None }, compiler: Compiler { stage: 2, host: TargetSelection { triple: "i686-pc-windows-msvc", file: None } } } -- 0.000
Check compiletest suite=ui-fulldeps mode=ui (i686-pc-windows-msvc -> i686-pc-windows-msvc)

running 67 tests
test [ui] src/test\ui-fulldeps\dropck-tarena-unsound-drop.rs ... ok
test [ui] src/test\ui-fulldeps\dropck-tarena-cycle-checked.rs ... ok
test [ui] src/test\ui-fulldeps\deriving-hygiene.rs ... ok
test [ui] src/test\ui-fulldeps\create-dir-all-bare.rs ... ok
test [ui] src/test\ui-fulldeps\deriving-global.rs ... ok
test [ui] src/test\ui-fulldeps\extern-mod-syntax.rs ... ok
test [ui] src/test\ui-fulldeps\dropck_tarena_sound_drop.rs ... ok
test [ui] src/test\ui-fulldeps\hash-stable-is-unstable.rs ... ok
test [ui] src/test\ui-fulldeps\feature-gate-plugin.rs ... ok
test [ui] src/test\ui-fulldeps\gated-plugin.rs ... ok
test [ui] src/test\ui-fulldeps\deriving-encodable-decodable-cell-refcell.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\default_hash_types.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\existing_doc_keyword.rs ... ok
test [ui] src/test\ui-fulldeps\empty-struct-braces-derive.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\query_stability.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\query_stability_incorrect.rs ... ok
test [ui] src/test\ui-fulldeps\compiler-calls.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\qualified_ty_ty_ctxt.rs ... ok
test [ui] src/test\ui-fulldeps\deriving-encodable-decodable-box.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\lint_pass_impl_without_macro.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\rustc_pass_by_value.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\ty_tykind_usage.rs ... ok
test [ui] src/test\ui-fulldeps\internal-lints\rustc_pass_by_value_self.rs ... ok
test [ui] src/test\ui-fulldeps\issue-14021.rs ... ok
test [ui] src/test\ui-fulldeps\issue-16822.rs ... ok
test [ui] src/test\ui-fulldeps\issue-15924.rs ... ok
test [ui] src/test\ui-fulldeps\issue-18502.rs ... ok
test [ui] src/test\ui-fulldeps\issue-11881.rs ... ok
test [ui] src/test\ui-fulldeps\issue-76270-panic-in-libproc-macro.rs ... ignored
test [ui] src/test\ui-fulldeps\issue-13560.rs ... ok
test [ui] src/test\ui-fulldeps\issue-2804.rs ... ok
test [ui] src/test\ui-fulldeps\issue-24106.rs ... ok
test [ui] src/test\ui-fulldeps\issue-15149.rs ... ok
test [ui] src/test\ui-fulldeps\lint-pass-macros.rs ... ok
test [ui] src/test\ui-fulldeps\lint-group-denied-lint-allowed.rs ... ok
test [ui] src/test\ui-fulldeps\lint-group-forbid-always-trumps-cli.rs ... ok
test [ui] src/test\ui-fulldeps\lint-group-plugin-deny-cmdline.rs ... ok
test [ui] src/test\ui-fulldeps\lint-group-plugin.rs ... ok
test [ui] src/test\ui-fulldeps\issue-40001.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-cmdline-allow.rs ... ok
test [ui] src/test\ui-fulldeps\issue-15778-fail.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-deny-attr.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-cmdline-load.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-deny-cmdline.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-forbid-cmdline.rs ... ok
test [ui] src/test\ui-fulldeps\macro-crate-rlib.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin-forbid-attrs.rs ... ok
test [ui] src/test\ui-fulldeps\issue-15778-pass.rs ... ok
test [ui] src/test\ui-fulldeps\multiple-plugins.rs ... ok
test [ui] src/test\ui-fulldeps\pathless-extern-unstable.rs ... ok
test [ui] src/test\ui-fulldeps\lint-plugin.rs ... ok
test [ui] src/test\ui-fulldeps\outlive-expansion-phase.rs ... ok
test [ui] src/test\ui-fulldeps\lint-tool-test.rs ... ok
test [ui] src/test\ui-fulldeps\plugin-args.rs ... ok
test [ui] src/test\ui-fulldeps\lint-tool-cmdline-allow.rs ... ok
test [ui] src/test\ui-fulldeps\plugin-as-extern-crate.rs ... ok
test [ui] src/test\ui-fulldeps\rustc_encodable_hygiene.rs ... ok
test [ui] src/test\ui-fulldeps\rename-directory.rs ... ok
test [ui] src/test\ui-fulldeps\session-derive-errors.rs ... ok
test [ui] src/test\ui-fulldeps\switch-stdout.rs ... ok
test [ui] src/test\ui-fulldeps\uninit_mask.rs ... ok
test [ui] src/test\ui-fulldeps\regions-mock-tcx.rs ... ok
test [ui] src/test\ui-fulldeps\stdio-from.rs ... FAILED
test [ui] src/test\ui-fulldeps\lto-syntax-extension.rs ... ok
test [ui] src/test\ui-fulldeps\mod_dir_path_canonicalized.rs ... ok
test [ui] src/test\ui-fulldeps\myriad-closures.rs ... ok
test [ui] src/test\ui-fulldeps\pprust-expr-roundtrip.rs ... ok
failures:


---- [ui] src/test\ui-fulldeps\stdio-from.rs stdout ----
Some tests failed in compiletest suite=ui-fulldeps mode=ui host=i686-pc-windows-msvc target=i686-pc-windows-msvc
error: test run failed!
status: exit code: 101
status: exit code: 101
command: PATH="D:\a\rust\rust\build\i686-pc-windows-msvc\stage2\lib\rustlib\i686-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x86;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw32\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.3\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.322-6\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\ui-fulldeps\\stdio-from\\a.exe"
stdout: none
--- stderr -------------------------------
I/O error: operation failed to complete synchronously
thread 'main' panicked at 'assertion failed: child2.wait()?.success()', D:\a\rust\rust\src/test\ui-fulldeps\stdio-from.rs:50:5
------------------------------------------




failures:
    [ui] src/test\ui-fulldeps\stdio-from.rs
test result: FAILED. 65 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 26.37s

Build completed unsuccessfully in 0:38:11
Build completed unsuccessfully in 0:38:11
make: *** [Makefile:72: ci-subset-1] Error 1

@jyn514
Copy link
Member Author

jyn514 commented Apr 6, 2022

Error message from less than one day merged #95469, so maybe not spurious.

I don't see how. That only affects File APIs, and the error was in Command::spawn.

@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95352 ([bootstrap] Print the full relative path to failed tests)
 - rust-lang#95646 (Mention `std::env::var` in `env!`)
 - rust-lang#95708 (Update documentation for `trim*` and `is_whitespace` to include newlines)
 - rust-lang#95714 (Add test for issue rust-lang#83474)
 - rust-lang#95725 (Message: Chunks cannot have a size of zero.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7499a8 into rust-lang:master Apr 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 7, 2022
@jyn514 jyn514 deleted the full-relative-path branch April 7, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants