Only tag data if debug assertions are enabled.

[cjgillot]

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 3154b78 with merge 8c1825bc6181da5cf5150a4caa5def113f1fb3da...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8c1825bc6181da5cf5150a4caa5def113f1fb3da (8c1825bc6181da5cf5150a4caa5def113f1fb3da)

[rust-timer]

Queued 8c1825bc6181da5cf5150a4caa5def113f1fb3da with parent fbdb10f, future comparison URL.

[rust-timer]

Finished benchmarking commit (8c1825bc6181da5cf5150a4caa5def113f1fb3da): comparison url.

Summary:

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	0	17	17	17
mean2	N/A	N/A	-0.3%	-0.4%	-0.3%
max	N/A	N/A	-0.3%	-0.7%	-0.3%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. number of relevant changes ↩

2. the arithmetic mean of the percent change ↩

[cjgillot]

I'm not really sure that losing the capability is worth it, but at the same time I don't remember ever seeing an ICE triggered by this.

r? rust-lang/compiler

[nagisa]

Do I understand correctly that rustc will handle the different encodings correctly and evict the cache properly when running two rustc builds from the same commit, one with debug assertions enabled and another with them disabled?

[apiraino]

Switching to waiting on author to incorporate changes (see previous comment). Feel free to request a review when ready, thanks!

@rustbot author

[JohnCSimon]

@cjgillot
ping from triage - can you post your status on this PR? This has sat unmoved for a while now. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.