Skip to content

[don't merge] See what happens if we run PGO on Apple #96732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented May 5, 2022

Currently, PGO is executed on CI only for the x64 linux target. It could be quite helpful for compiler performance (and possibly not that difficult) to also run it for other important targets, like OS X and Windows. This is just an experimental PR where we want to try how could we achieve that.

I modified the CI workflows so that they will try to run apple try build after each push.

r? @lqd

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2022
@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol force-pushed the ci-pgo-osx branch 2 times, most recently from c5de5eb to 8e1d616 Compare May 5, 2022 12:17
@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Member Author

Kobzol commented May 12, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 968beaf291e14ef8c95397b3e5c279a339c5ac2d with merge d007f66a589d5f8534d710af7fdf5c480fded63b...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2022
@Kobzol
Copy link
Member Author

Kobzol commented May 12, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 5b632ff3b6692440b2250eabdc90ba294df2efab with merge 771ef42acff5fb9e0bc90317b84c8c28917b696f...

@bors
Copy link
Collaborator

bors commented May 12, 2022

💔 Test failed - checks-actions

@Kobzol
Copy link
Member Author

Kobzol commented May 12, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit ab19f43ad135f1351a2e96ea38edcfde840ac340 with merge ea39a518964de0ac1b93a3d637ed012e889ad53d...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Try build successful - checks-actions
Build commit: ea39a518964de0ac1b93a3d637ed012e889ad53d (ea39a518964de0ac1b93a3d637ed012e889ad53d)

@thomcc thomcc added the O-macos Operating system: macOS label May 13, 2022
@Kobzol
Copy link
Member Author

Kobzol commented May 13, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 13, 2022

⌛ Trying commit c85fc48a9fb448f37ce737817e86b8a052355c21 with merge 9517e2ba541f873e5fdff271f52597b783acbdf6...

@bors
Copy link
Collaborator

bors commented May 13, 2022

☀️ Try build successful - checks-actions
Build commit: 9517e2ba541f873e5fdff271f52597b783acbdf6 (9517e2ba541f873e5fdff271f52597b783acbdf6)

@Kobzol
Copy link
Member Author

Kobzol commented May 14, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 14, 2022

⌛ Trying commit 67fc90a with merge 32aa173804582e19f5f6a0bcebda41e3e2676755...

@bors
Copy link
Collaborator

bors commented May 14, 2022

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Member Author

Kobzol commented May 14, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 14, 2022

⌛ Trying commit 91d0c93 with merge b20a7ad4c3cae39d79d6f074acbdacd31bf1581a...

@bors
Copy link
Collaborator

bors commented May 14, 2022

☀️ Try build successful - checks-actions
Build commit: b20a7ad4c3cae39d79d6f074acbdacd31bf1581a (b20a7ad4c3cae39d79d6f074acbdacd31bf1581a)

@Kobzol
Copy link
Member Author

Kobzol commented May 24, 2022

The OS X CI runners currently don't have enough resources to run full PGO. We can either try to apply artifacts from Linux or, if full PGO on Windows is successful, maybe some more resources could be provided for OS X in the future.

@Kobzol Kobzol closed this May 24, 2022
@Kobzol Kobzol deleted the ci-pgo-osx branch May 24, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-macos Operating system: macOS S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants