Detect trait fulfillment in subst_and_check_impossible_predicates
#96808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
approved these changes
May 7, 2022
| @@ -432,6 +432,9 @@ pub fn impossible_predicates<'tcx>( | |||
| debug!("impossible_predicates(predicates={:?})", predicates); | |||
|
|
|||
| let result = tcx.infer_ctxt().enter(|infcx| { | |||
| // Set tainted by errors to gracefully exit in case of overflow. | |||
There was a problem hiding this comment.
I would mark this as HACK or something, since it's technically not using the flag correctly, right? I think it's fine otherwise.
|
@bors r=compiler-errors |
|
📌 Commit 69e5b2f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (2226f19): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #91743
r? @compiler-errors