Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 27, 2022

Previously, this would break because the submodule wasn't checked out.

Fixes #97464.

Previously, this would break because the submodule wasn't checked out.
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 28, 2022

📌 Commit 6f5de28 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2022
@bors
Copy link
Collaborator

bors commented May 28, 2022

⌛ Testing commit 6f5de28 with merge b97bfc3...

@bors
Copy link
Collaborator

bors commented May 28, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b97bfc3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 28, 2022
@bors bors merged commit b97bfc3 into rust-lang:master May 28, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 28, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b97bfc3): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
0.3% 0.3% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 0.3% 0.3% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
3.6% 3.6% 1
Regressions 😿
(secondary)
2.3% 2.3% 1
Improvements 🎉
(primary)
-2.5% -2.9% 2
Improvements 🎉
(secondary)
-1.8% -2.4% 3
All 😿🎉 (primary) -0.5% 3.6% 3

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
2.9% 2.9% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-2.1% -2.1% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 0.4% 2.9% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@jyn514 jyn514 deleted the dist-ra branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./x.py dist --stage 1 fails on due to rust-analyzer submodule not being checked out automatically
6 participants