Rollup of 5 pull requests #97996
Merged
Rollup of 5 pull requests #97996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code will not results bug, but it difficult to understand. These code result to call &f32::partial_cmp(), and the performance will be lower than the changed code. I'm not sure why the current code don't use (*self) (*other), if you have some idea, please let me know.
This change causes passes specified in -Cpasses= to be applied only during pre-link optimization, not during LTO. This avoids such passes running multiple times, which they may not be designed for. Fixes rust-lang#97713
line 1352, delete parentheses for reviewers asking for it.
Small grammar fix in the compile_error documentation
line 1352, change `self` to `*self`, other to `*other` The current code will not results bug, but it difficult to understand. These code result to call &f32::partial_cmp(), and the performance will be lower than the changed code. I'm not sure why the current code don't use (*self) (*other), if you have some idea, please let me know.
Make -Cpasses= only apply to pre-link optimization This change causes passes specified in -Cpasses= to be applied only during pre-link optimization, not during LTO. This avoids such passes running multiple times, which they may not be designed for. Fixes rust-lang#97713
…an-DPC Add more eslint checks List of newly added checks: * [no-lonely-if](https://eslint.org/docs/rules/no-lonely-if) * [no-mixed-operators](https://eslint.org/docs/rules/no-mixed-operators) * [no-multi-assign](https://eslint.org/docs/rules/no-multi-assign) * [no-return-assign](https://eslint.org/docs/rules/no-return-assign) * [no-script-url](https://eslint.org/docs/rules/no-script-url) r? `@Dylan-DPC`
feat(fix): update some links in `hir.rs` This PR fixes some links in `hir.rs`. The relative paths seem to be different from when this comment was committed. ref: - related commit rust-lang@1e6adad - current page https://doc.rust-lang.org/beta/nightly-rustc/rustc_hir/hir/enum.QPath.html https://doc.rust-lang.org/beta/nightly-rustc/rustc_hir/hir/enum.ExprKind.html#variant.MethodCall Thank you in advance.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 178cffe has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c08b235): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
selfto*self, other to*other)hir.rs#97994 (feat(fix): update some links inhir.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup