Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #98037

Merged
merged 6 commits into from
Jun 13, 2022
Merged

Rollup of 3 pull requests #98037

merged 6 commits into from
Jun 13, 2022

Conversation

compiler-errors
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

eggyal and others added 6 commits June 10, 2022 16:26
@eggyal
Clarify #[derive(PartialEq)] on enums
7bbf914 
Fixes rust-lang#97945
@bjorn3
Fix some test annotations
2f47edb 
These are necessary for running the rustc test suite with cg_clif
@onlineSoftwareDevOK
Add comment for internal error codes
99672fb
@compiler-errors
Rollup merge of rust-lang#97920 - bjorn3:test_annotation_fixes, r=Dyl…
6efaaed 
…an-DPC

Fix some test annotations

These are necessary for running the rustc test suite with cg_clif.
@compiler-errors
Rollup merge of rust-lang#97950 - eggyal:issue-97945, r=Dylan-DPC
5dccf4e 
Clarify `#[derive(PartialEq)]` on enums

Fixes rust-lang#97945
@compiler-errors
Rollup merge of rust-lang#98011 - onlineSoftwareDevOK:long-error-expl…
ac73b19 
…anation-e0208, r=GuillaumeGomez

Add documentation for error E0208

Related to rust-lang#61137
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 13, 2022
@compiler-errors
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit ac73b19 has been approved by compiler-errors

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 13, 2022
@bors
Copy link
Contributor

bors commented Jun 13, 2022

⌛ Testing commit ac73b19 with merge c570ab5...

@bors
Copy link
Contributor

bors commented Jun 13, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c570ab5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2022
@bors bors merged commit c570ab5 into rust-lang:master Jun 13, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 13, 2022
@bors bors mentioned this pull request Jun 13, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c570ab5): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 2.7% 2.7% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.9% -1.9% 1
All 😿🎉 (primary) 2.7% 2.7% 1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@compiler-errors compiler-errors deleted the rollup-fbvy456 branch August 11, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@compiler-errors @bors @rust-timer @rustbot @eggyal @bjorn3 @onlineSoftwareDevOK