Skip to content

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jun 29, 2022

Closes #98658

r? @GuillaumeGomez

@rustbot labels +A-rustdoc-json

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jun 29, 2022
@GuillaumeGomez
Copy link
Member

Thanks! I'll approve it once CI pass.

@GuillaumeGomez
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

📌 Commit ba87c93 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2022
…type-blanket-impl, r=GuillaumeGomez

rustdoc-json: Make default value of blanket impl assoc types work

Closes rust-lang#98658

r? `@GuillaumeGomez`

`@rustbot` labels +A-rustdoc-json
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#96727 (Make TAIT behave exactly like RPIT)
 - rust-lang#98681 (rustdoc-json: Make default value of blanket impl assoc types work)
 - rust-lang#98682 (add tests for ICE 94432)
 - rust-lang#98683 (add test for ice 68875)
 - rust-lang#98685 (Replace `sort_modules_alphabetically` boolean with enum)
 - rust-lang#98687 (add test for 47814)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d6b30c into rust-lang:master Jun 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 30, 2022
@Enselic Enselic deleted the rustdoc-json-default-assoc-type-blanket-impl branch June 30, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc-json: Default value of assoc type in blanket impls missing
5 participants