Remove EntryKind from metadata. #98960

cjgillot · 2022-07-05T20:19:22Z

This PR continues the refactor of metadata emission to be more systematic, iterating on definitions and filtering based on each definition's DefKind. This allows to remove the large EntryKind enum, replaced by linear tables in metadata.

cjgillot · 2022-07-05T20:19:30Z

@bors try @rust-timer queue

rust-timer · 2022-07-05T20:19:31Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-05T20:19:42Z

⌛ Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge a4011cb6eef91e3830bdf2f739c3b5140ce6720a...

bors · 2022-07-05T20:21:47Z

💔 Test failed - checks-actions

cjgillot · 2022-07-05T20:58:58Z

@bors try @rust-timer queue

rust-timer · 2022-07-05T20:58:59Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-05T20:59:05Z

⌛ Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge d39a35a69b824686f9f79ec1e99fa347a28d685f...

bors · 2022-07-05T22:32:42Z

☀️ Try build successful - checks-actions
Build commit: d39a35a69b824686f9f79ec1e99fa347a28d685f (d39a35a69b824686f9f79ec1e99fa347a28d685f)

rust-timer · 2022-07-05T22:32:43Z

Queued d39a35a69b824686f9f79ec1e99fa347a28d685f with parent 41ad4d9, future comparison URL.

rust-timer · 2022-07-06T03:21:54Z

Finished benchmarking commit (d39a35a69b824686f9f79ec1e99fa347a28d685f): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.6%	2.6%	55
Regressions 😿 (secondary)	2.0%	8.4%	38
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.3%	-2.2%	9
All 😿🎉 (primary)	0.6%	2.6%	55

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	2.3%	4.9%	85
Regressions 😿 (secondary)	4.4%	8.1%	84
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.6%	-3.2%	12
All 😿🎉 (primary)	2.3%	4.9%	85

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.0%	5.8%	16
Improvements 🎉 (primary)	-3.4%	-3.4%	1
Improvements 🎉 (secondary)	-3.9%	-6.1%	10
All 😿🎉 (primary)	-3.4%	-3.4%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

cjgillot · 2022-07-06T09:31:32Z

@bors try @rust-timer queue

rust-timer · 2022-07-06T09:31:34Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-06T09:31:41Z

⌛ Trying commit adb0576b6c900e8dc7f2272bc0ff50afdde590b9 with merge 46ef832c457b61f5d20f548ba382df88edb88f58...

bjorn3 · 2022-07-06T10:50:26Z

Last perf run suggests that both the crate metadata and the dep graph got bigger.

bors · 2022-07-06T11:22:05Z

☀️ Try build successful - checks-actions
Build commit: 46ef832c457b61f5d20f548ba382df88edb88f58 (46ef832c457b61f5d20f548ba382df88edb88f58)

rust-timer · 2022-07-06T11:22:07Z

Queued 46ef832c457b61f5d20f548ba382df88edb88f58 with parent 5b8cf49, future comparison URL.

rust-timer · 2022-07-06T12:37:01Z

Finished benchmarking commit (46ef832c457b61f5d20f548ba382df88edb88f58): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	0.5%	0.7%	11
Regressions 😿 (secondary)	0.7%	0.9%	6
Improvements 🎉 (primary)	-0.5%	-0.5%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.5%	0.7%	12

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	2.5%	4.6%	101
Regressions 😿 (secondary)	4.9%	11.1%	87
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.3%	-2.5%	4
All 😿🎉 (primary)	2.5%	4.6%	101

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	2.8%	2.8%	1
Regressions 😿 (secondary)	3.2%	3.4%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.8%	2.8%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

bors · 2022-08-29T23:15:50Z

☔ The latest upstream changes (presumably #101152) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2022-09-01T16:31:08Z

@bors r+ rollup=never

bors · 2022-09-01T16:31:11Z

📌 Commit 60a052f has been approved by estebank

It is now in the queue for this repository.

bors · 2022-09-01T19:31:17Z

⌛ Testing commit 60a052f with merge 2e35f95...

bors · 2022-09-01T22:12:25Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2e35f95 to master...

rust-timer · 2022-09-01T23:28:03Z

Finished benchmarking commit (2e35f95): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.1%, 1.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.4%	[0.5%, 2.3%]	9
Regressions ❌ (secondary)	3.0%	[1.5%, 8.8%]	68
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-6.2%, -2.3%]	7
All ❌✅ (primary)	1.4%	[0.5%, 2.3%]	9

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 5, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 5, 2022

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 5, 2022

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 6, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2022

Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022

cjgillot added 13 commits August 30, 2022 19:04

Encode type in the main loop.

45ad22b

Encode consts in metadata main loop.

73e9f37

Simplify recursion scheme.

edd25c3

Move VariantData to a metadata table.

927e58d

Move AssocContainer to a metadata table.

ca9f564

Use tables for macros.

1ddb944

Create a table for fn_has_self_parameter.

30ae64e

Fix the panic message.

d330dc8

Create a module-reexports table.

affb122

Remove EntryKind.

c485fcc

Separate macro_rules and macro_definition.

b0b46c0

Remove fn_has_self_parameter table.

b94d421

Handle MIR in a single place.

60a052f

cjgillot force-pushed the entry-kind branch from bc61835 to 60a052f Compare August 30, 2022 17:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2022

bors merged commit 2e35f95 into rust-lang:master Sep 1, 2022

rustbot added this to the 1.65.0 milestone Sep 1, 2022

This was referenced Sep 1, 2022

Do not call object_lifetime_default on lifetime params. #101214

Merged

Initial implementation of return-position impl Trait in traits #101224

Merged

avoid using mk_attr_id when decoding #101269

Closed

rustbot removed the perf-regression Performance regression. label Sep 1, 2022

cjgillot deleted the entry-kind branch September 2, 2022 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove EntryKind from metadata. #98960

Remove EntryKind from metadata. #98960

cjgillot commented Jul 5, 2022 •

edited

Loading

cjgillot commented Jul 5, 2022

rust-timer commented Jul 5, 2022

bors commented Jul 5, 2022

This comment has been minimized.

bors commented Jul 5, 2022

cjgillot commented Jul 5, 2022

rust-timer commented Jul 5, 2022

bors commented Jul 5, 2022

bors commented Jul 5, 2022

rust-timer commented Jul 5, 2022

rust-timer commented Jul 6, 2022

cjgillot commented Jul 6, 2022

rust-timer commented Jul 6, 2022

bors commented Jul 6, 2022

bjorn3 commented Jul 6, 2022

bors commented Jul 6, 2022

rust-timer commented Jul 6, 2022

rust-timer commented Jul 6, 2022

bors commented Aug 29, 2022

estebank commented Sep 1, 2022

bors commented Sep 1, 2022

bors commented Sep 1, 2022

bors commented Sep 1, 2022

rust-timer commented Sep 1, 2022

Remove EntryKind from metadata. #98960

Remove EntryKind from metadata. #98960

Conversation

cjgillot commented Jul 5, 2022 • edited Loading

cjgillot commented Jul 5, 2022

rust-timer commented Jul 5, 2022

bors commented Jul 5, 2022

This comment has been minimized.

bors commented Jul 5, 2022

cjgillot commented Jul 5, 2022

rust-timer commented Jul 5, 2022

bors commented Jul 5, 2022

bors commented Jul 5, 2022

rust-timer commented Jul 5, 2022

rust-timer commented Jul 6, 2022

Footnotes

cjgillot commented Jul 6, 2022

rust-timer commented Jul 6, 2022

bors commented Jul 6, 2022

bjorn3 commented Jul 6, 2022

bors commented Jul 6, 2022

rust-timer commented Jul 6, 2022

rust-timer commented Jul 6, 2022

Footnotes

bors commented Aug 29, 2022

estebank commented Sep 1, 2022

bors commented Sep 1, 2022

bors commented Sep 1, 2022

bors commented Sep 1, 2022

rust-timer commented Sep 1, 2022

Overall result: ❌ regressions - no action needed

Footnotes

cjgillot commented Jul 5, 2022 •

edited

Loading