Skip to content

[do not merge] Undo all recent deriving changes. #99446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nnethercote
Copy link
Contributor

As an experiment, to see the combined performance effect.

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 19, 2022
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 19, 2022
@bors
Copy link
Collaborator

bors commented Jul 19, 2022

⌛ Trying commit a1cdab838084e0822f5049f7eb623389148595b3 with merge 86ee43624628efb1c491ad9749a96a832de846e5...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 19, 2022

☀️ Try build successful - checks-actions
Build commit: 86ee43624628efb1c491ad9749a96a832de846e5 (86ee43624628efb1c491ad9749a96a832de846e5)

@rust-timer
Copy link
Collaborator

Queued 86ee43624628efb1c491ad9749a96a832de846e5 with parent 475aec1, future comparison URL.

As an experiment, to see the combined performance effect.
@nnethercote nnethercote force-pushed the undo-deriving-changes branch from a1cdab8 to af8775b Compare July 19, 2022 05:46
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jul 19, 2022

⌛ Trying commit af8775b with merge 3e5b7142a8a24200ec4d00d7d0c0f176321d3fe4...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (86ee43624628efb1c491ad9749a96a832de846e5): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
1.7% 7.2% 124
Regressions 😿
(secondary)
6.6% 31.1% 52
Improvements 🎉
(primary)
-0.8% -1.5% 3
Improvements 🎉
(secondary)
-1.4% -2.3% 13
All 😿🎉 (primary) 1.6% 7.2% 127

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
1.6% 3.8% 38
Regressions 😿
(secondary)
5.3% 9.9% 21
Improvements 🎉
(primary)
-4.4% -6.0% 4
Improvements 🎉
(secondary)
-4.0% -4.5% 2
All 😿🎉 (primary) 1.1% -6.0% 42

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
3.4% 9.0% 52
Regressions 😿
(secondary)
9.8% 39.4% 40
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 3.4% 9.0% 52

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 19, 2022
@bors
Copy link
Collaborator

bors commented Jul 19, 2022

☀️ Try build successful - checks-actions
Build commit: 3e5b7142a8a24200ec4d00d7d0c0f176321d3fe4 (3e5b7142a8a24200ec4d00d7d0c0f176321d3fe4)

@Mark-Simulacrum
Copy link
Member

Closing as results are available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants