Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document stabilization PRs for the standard library #932

Closed
jyn514 opened this issue Oct 23, 2020 · 3 comments · Fixed by #1036
Closed

Document stabilization PRs for the standard library #932

jyn514 opened this issue Oct 23, 2020 · 3 comments · Fixed by #1036
Assignees
@jyn514
Labels
Easy Might be a good place for a beginner

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 23, 2020

Right now https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr is very geared towards the compiler itself. We should document what a stabilization PR looks like for the standard library. Info here: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/const.20alloc.3A.3ALayout and example PR: rust-lang/rust#75132

I'm imagining this as a separate page from stabilization_guide to make it easier to find in the table of contents, but I'm not super tied to that.
@jyn514 jyn514 added the Easy Might be a good place for a beginner label Oct 23, 2020
@jyn514 jyn514 mentioned this issue Dec 4, 2020
Merged
@jyn514 jyn514 mentioned this issue Jan 13, 2021
Closed
5 tasks
@m-ou-se
Copy link
Member

m-ou-se commented Jan 23, 2021

This missing documentation caused more confusion yet again in rust-lang/rust#73831.

We should fix this. (:

@m-ou-se
Copy link
Member

m-ou-se commented Jan 23, 2021

Our most up-to-date info on this is: https://raw.githubusercontent.com/rust-lang/rust/master/.github/ISSUE_TEMPLATE/library_tracking_issue.md

@jyn514 jyn514 self-assigned this Jan 23, 2021
@jyn514 jyn514 mentioned this issue Jan 23, 2021
Merged
@KodrAus
Copy link

KodrAus commented Jan 24, 2021

There's nothing there yet, but we do have a repo now that we should definitely document this in: https://github.com/rust-lang/std-dev-guide

@jyn514 jyn514 mentioned this issue Jan 24, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyn514 jyn514

Labels
Easy Might be a good place for a beginner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document how to stabilize a library feature jyn514/rustc-dev-guide
3 participants
@m-ou-se @KodrAus @jyn514