Change the feature used as an example of stabilizing lib features #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous one was not following the process: it was a PR, which an FCP was started on after the fact. This doesn't match what the stated process is: we should instead link to an issue where t-libs started an fcp, then a pr was written later.
JohnTitor
reviewed
Jun 12, 2021
src/stability.md
Outdated
| @@ -85,7 +85,7 @@ To stabilize a feature, follow these steps: | |||
| - Add the appropriate labels: `@rustbot modify labels: +T-libs`. | |||
| - Link to the tracking issue and say "Closes #XXXXX". | |||
|
|
|||
| You can see an example of stabilizing a feature at [#75132](https://github.com/rust-lang/rust/pull/75132). | |||
| You can see an example of stabilizing a feature at [#81656](https://github.com/rust-lang/rust/issues/81656). | |||
There was a problem hiding this comment.
The section talks about how we create a PR so we should link to the PR, not the issue.
There was a problem hiding this comment.
I've added a link to both and clarified the wording so it points to all steps of the process. My understanding after talking to a t-libs member about this was that the idea of this section is to direct people to put fcp's and discussion on the merits of the feature on tracking issues prior to filing the implementation PR, to make it easier to follow.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 22, 2021
Update books ## nomicon 10 commits in 55de6fa3c1f331774da19472c9ee57d2ae9eb039..b9ca313e687c991223e23e5520529815dc281205 2021-05-12 00:31:01 +0900 to 2021-06-22 12:02:20 -0400 - The #[repr(C)] attribute on the callback example is not necessary, since the type is not used in C. - Reorganize some chapters (rust-lang/nomicon#282) - Mention "extern types" on the opaque structs section (rust-lang/nomicon#273) - Clarify the conditions on the aliasing section (rust-lang/nomicon#272) - Upgrade to edition 2018 (rust-lang/nomicon#280) - Update some wording making reference to issues/RFCs (rust-lang/nomicon#271) - Some improvements on the "subtyping" chapter (rust-lang/nomicon#278) - Clarify casting between the same size fixed ints (rust-lang/nomicon#277) - Add a link to show why unused lifetimes on structs are forbidden (rust-lang/nomicon#276) - Fix small typo in the Drop Check chapter (rust-lang/nomicon#275) ## reference 8 commits in 8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8..d9699fa8f3186440fdaadd703d63d8d42322c176 2021-06-01 19:00:46 +0100 to 2021-06-21 12:23:10 -0700 - Make explicit reference to scrutinee expression in grammar snippet (rust-lang/reference#1044) - Document sub-namespaces. (rust-lang/reference#1043) - Default all examples to 2018 edition. (rust-lang/reference#1041) - Minor update to macros. (rust-lang/reference#1048) - (rust-lang/reference#1049) - Add a note why the same size int casting is a no-op (rust-lang/reference#1046) - Add notes on `#[target_feature]` for wasm (rust-lang/reference#1047) - Make statement about variable visibility more precise (rust-lang/reference#1045) ## rustc-dev-guide 8 commits in c8da5bfd1c7c71d90ef1646f5e0a9f6609d5c78a..fe34beddb41dea5cb891032512a8d5b842b99696 2021-06-04 09:08:56 +0200 to 2021-06-21 21:50:12 +0200 - Update "Inference variables" section (rust-lang/rustc-dev-guide#1145) - Document how to run unit tests (rust-lang/rustc-dev-guide#1141) - We stopped using allow_internal_unstable a while ago (rust-lang/rustc-dev-guide#1142) - Change the feature used as an example of stabilizing lib features (rust-lang/rustc-dev-guide#1143) - We use HIR to do type inference, trait solving and type checking (rust-lang/rustc-dev-guide#1139) - Add suggested settings note for coc (rust-lang/rustc-dev-guide#1144) - move 7/8 to prose - Add a section on keeping things up to date in the git section ## edition-guide 2 commits in 302a115e8f71876dfc884aebb0ca5ccb02b8a962..c74b2a0d6bf55774cf15d69f05dfe05408b8f81a 2021-05-21 10:46:11 -0400 to 2021-06-14 10:48:27 -0700 - Fix lies. (rust-lang/edition-guide#244) - Add short summaries to all 2021 edition changes. (rust-lang/edition-guide#243) ## embedded-book 1 commits in 7349d173fa28a0bb834cf0264a05286620ef0923..cbec77fbd8eea0c13e390dd9eded1ae200e811d1 2021-05-25 13:59:05 +0000 to 2021-06-10 06:26:32 +0000 - Fix punctuation in c-with-rust.md (rust-embedded/book#294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous one was not following the process we're documenting: it was a PR, which an FCP was started on after the fact. This doesn't match what the stated process is: we should instead link to an issue where t-libs started an fcp, then a pr was written later.