Skip to content

make date-check more easy to use #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2022
Merged

make date-check more easy to use #1428

merged 2 commits into from
Aug 26, 2022

Conversation

tshepang
Copy link
Member

One could not run it like the following, for the would be a panic:

cargo run --manifest-path ci/date-check/Cargo.toml .

jyn514
jyn514 requested changes Aug 14, 2022
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than removing this functionality altogether, can you make root_dir using CARGO_MANIFEST_PATH or something like that? Or use unwrap_or instead of unwrap?

@tshepang
make date-check more easy to use
87cece7 
One could not run it like the following, for the would be a panic:

    cargo run --manifest-path ci/date-check/Cargo.toml .

Also, remove the need to specify argument, in which case, current_dir
is assumed.
@tshepang
Copy link
Member Author

thanks for the suggestion... didn't notice I made some things less pretty

@tshepang tshepang requested a review from jyn514 August 16, 2022 02:55
@JohnTitor JohnTitor added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 17, 2022
camelid
camelid requested changes Aug 17, 2022
View reviewed changes
@camelid camelid added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Aug 17, 2022
@tshepang tshepang requested a review from camelid August 24, 2022 04:16
camelid
camelid approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid camelid merged commit b0a0a4f into rust-lang:master Aug 26, 2022
@tshepang tshepang deleted the flexible branch August 26, 2022 04:13
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Dec 30, 2024
@tshepang @camelid
address review comment
f705657 
rust-lang/rustc-dev-guide#1428 (comment)
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
@tshepang @camelid
address review comment
dfb4949 
rust-lang/rustc-dev-guide#1428 (comment)
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025
@tshepang @camelid
address review comment
dc6fcae 
rust-lang#1428 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

@camelid camelid camelid approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tshepang @jyn514 @camelid @JohnTitor