remove outdated text about wfx implies #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
S-waiting-on-review
Closed
|
Hey, thank you for the PR! However you should remove the text in https://rustc-dev-guide.rust-lang.org/solve/invariants.html#wfx-implies-wfnormalizex- instead, see the issue. |
patrickoliveira15
force-pushed
the
patch/inference-invariance
branch
from
4f5fdb9 to
2589421
Compare
Oops, my bad! 😅 @JohnTitor Thanks for pointing me in the right direction! |
patrickoliveira15
changed the title
|
Adjusted! |
JohnTitor
reviewed
Jan 17, 2025
|
Left one comment otherwise LGTM! |
patrickoliveira15
force-pushed
the
patch/inference-invariance
branch
from
2589421 to
fbceffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the outdated comment about wfx implies, as the issue has been resolved.
The issue was discussed in rust-lang/rustc-dev-guide#2161, and @JohnTitor confirmed that it is fixed:
Fixes #2161