Change rustc::* to rustc_middle::*
#798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giraffate
force-pushed
the
change_rustc_to_rustc_middle
branch
from
464f8d3 to
e3d1a4b
Compare
JohnTitor
requested changes
Jul 15, 2020
There was a problem hiding this comment.
We can also update them following the comments:
https://github.com/rust-lang/rustc-dev-guide/blob/master/src/compiler-debugging.md#L177-L183
It seems the profiling perf chapter is also slightly outdated but I think it's better to go in another PR.
Thanks for your information! It seems good.
Yes. I try another PR. |
|
The test seems to fail for another cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it looks like
rustc_middle::*is used notrustc::*.I didn't change everything. For example, I didn't know if I should change
src/compiler-debugging.mdbecause it includes the backtrace message.