Get host tuple from rustc used for benchmarking/profiling, if possible #2276
+65
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
host-tuple-dynamic
branch
from
36ae8d5 to
4ebd004
Compare
lqd
approved these changes
Oct 10, 2025
| None => get_host_tuple_from_rustc("rustc"), | ||
| }; | ||
| // We only unwrap the host tuple in places where we actually need it, to avoid panicking if it | ||
| // is missing, but we don't really need it. |
There was a problem hiding this comment.
I guess technically we wouldn't have needed to run the command in the first place, not just avoid checking its result. I guess it only will make 1 rustc call per rustc-perf command so it's not that bad, and we'll most likely actually need that 1 invocation.
|
oops I didn't catch the "fix rust-lang/rust#147515" in the OP that would cause github to close the PR ... |
dianqk
added a commit
to dianqk/rust
that referenced
this pull request
Oct 10, 2025
…ethercote Update rustc-perf submodule To bring in rust-lang/rustc-perf#2274, rust-lang/rustc-perf#2275 and rust-lang/rustc-perf#2276. r? `@nnethercote` try-job: dist-x86_64-linux try-job: dist-x86_64-msvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix rust-lang/rust#147515.
r? @lqd