Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 9, 2025

To bring in rust-lang/rustc-perf#2274, rust-lang/rustc-perf#2275 and rust-lang/rustc-perf#2276.

r? @nnethercote

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

⚠️ Warning ⚠️

@Kobzol
Copy link
Member Author

Kobzol commented Oct 9, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 9, 2025
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with clean perf

View changes since this review

@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: a69399c (a69399c14b307c881534efc6e638e2e26acd7eca, parent: bd3487101ff9397ca8a54dd83aa360d93342b82e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a69399c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.7% [4.7%, 4.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.7% [4.7%, 4.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.495s -> 472.636s (-0.39%)
Artifact size: 388.40 MiB -> 388.41 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 9, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Oct 9, 2025

@bors r=lqd,nnethercote rollup

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit 0624882 has been approved by lqd,nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 9, 2025
…ethercote

Update rustc-perf submodule

To bring in rust-lang/rustc-perf#2274.

r? `@nnethercote`
bors added a commit that referenced this pull request Oct 9, 2025
Rollup of 4 pull requests

Successful merges:

 - #147447 (Set the minimum deployment target for `aarch64-apple-watchos`)
 - #147479 (cmse: improve error messages)
 - #147515 (Update rustc-perf submodule)
 - #147523 (x86_64-bigint-helpers test: update test assertion to cover registers r8 and r9)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
guess this failed here? :ferrisclueless:

#147531 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Oct 10, 2025

Oops. rust-lang/rustc-perf#2275 should fix this.

@Kobzol Kobzol marked this pull request as draft October 10, 2025 11:00
@Kobzol Kobzol force-pushed the update-rustc-perf branch from 0624882 to 11fc82c Compare October 10, 2025 11:33
@Kobzol
Copy link
Member Author

Kobzol commented Oct 10, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 10, 2025
Update rustc-perf submodule

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc
@rust-bors
Copy link

rust-bors bot commented Oct 10, 2025

💔 Test for add14c5 failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 10, 2025
@Kobzol Kobzol reopened this Oct 10, 2025
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 10, 2025
@Kobzol Kobzol force-pushed the update-rustc-perf branch from 11fc82c to ce671f9 Compare October 10, 2025 13:42
@Kobzol
Copy link
Member Author

Kobzol commented Oct 10, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Oct 10, 2025
Update rustc-perf submodule

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 10, 2025

☀️ Try build successful (CI)
Build commit: eae0292 (eae0292e4e44c89963d9586836c83272b0c1133e, parent: 9725c4baacef19345e13f91b27e66e10ef5592ae)

@Kobzol Kobzol marked this pull request as ready for review October 10, 2025 16:50
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 10, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Oct 10, 2025

Finally.

@bors r=lqd,nnethercote rollup

@bors
Copy link
Collaborator

bors commented Oct 10, 2025

📌 Commit ce671f9 has been approved by lqd,nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2025
bors added a commit that referenced this pull request Oct 10, 2025
Rollup of 12 pull requests

Successful merges:

 - #145651 (Regression test for const promotion with Option<Ordering>)
 - #145722 (implement Extend<{Group, Literal, Punct, Ident}> for TokenStream)
 - #146520 (Promote armv8r-none-eabihf target to Tier 2)
 - #146522 (Promote armv7a-none-eabihf to Tier 2)
 - #147289 (Mitigate `thread_local!` shadowing issues)
 - #147515 (Update rustc-perf submodule)
 - #147522 (compiletest: Use the same directive lines for EarlyProps and ignore/only/needs)
 - #147525 (Replace locals in debuginfo records during ref_prop and dest_prop)
 - #147544 (Remove StatementKind::Deinit.)
 - #147551 (remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of`)
 - #147553 (Move `wasm32-wasip3`  to the tier 3 table)
 - #147562 (Stabilize `NonZero<u*>::div_ceil`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 11, 2025
Rollup of 12 pull requests

Successful merges:

 - #145651 (Regression test for const promotion with Option<Ordering>)
 - #145722 (implement Extend<{Group, Literal, Punct, Ident}> for TokenStream)
 - #146520 (Promote armv8r-none-eabihf target to Tier 2)
 - #146522 (Promote armv7a-none-eabihf to Tier 2)
 - #147289 (Mitigate `thread_local!` shadowing issues)
 - #147515 (Update rustc-perf submodule)
 - #147522 (compiletest: Use the same directive lines for EarlyProps and ignore/only/needs)
 - #147525 (Replace locals in debuginfo records during ref_prop and dest_prop)
 - #147544 (Remove StatementKind::Deinit.)
 - #147551 (remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of`)
 - #147553 (Move `wasm32-wasip3`  to the tier 3 table)
 - #147562 (Stabilize `NonZero<u*>::div_ceil`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 046260e into rust-lang:master Oct 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 11, 2025
rust-timer added a commit that referenced this pull request Oct 11, 2025
Rollup merge of #147515 - Kobzol:update-rustc-perf, r=lqd,nnethercote

Update rustc-perf submodule

To bring in rust-lang/rustc-perf#2274, rust-lang/rustc-perf#2275 and rust-lang/rustc-perf#2276.

r? `@nnethercote`

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc
@Kobzol Kobzol deleted the update-rustc-perf branch October 11, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants