std_detect: Support detecting lse/dotprod/jsconv/rcpc on aarch64 Windows #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
taiki-e
force-pushed
the
std-detect-aarch64-windows
branch
from
285a2e6 to
c560629
Compare
|
Hmm, I ran the test on a windows VM on a mac m1 that supports all these features and it looks like the detection of FEAT_RCPC is not yet supported. |
bors bot
added a commit
to taiki-e/portable-atomic
that referenced
this pull request
Jan 24, 2023
63: aarch64: Support detecting FEAT_LSE on Windows r=taiki-e a=taiki-e As of nightly-2023-01-23, is_aarch64_feature_detected doesn't support detecting FEAT_LSE on Windows. A patch on stdarch side: rust-lang/stdarch#1373 Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsProcessorFeaturePresent currently supports the detection of more CPU features.
(IsProcessorFeaturePresent docs currently don't mention most of them but it appears there is a PR to update it)