New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dependencies to Cargo.toml requires restarting VScode #98
Comments
This should be fixed by updating the RLS (run |
Thanks for the quick response. I have just updated RLS and it seems to work: RLS monitors my Cargo.toml file and triggers a new analysis when it changes. The update changed the error message I got and I am not sure it is intended. I am working on the mpq crate which contains both a library and a binary. So, I am using the If my Cargo.toml file is missing a crate dependency, I now get the following error
Also, warning display no longer works ( |
This sounds like the right error? Does it go away when you add the dep for mpq to the Cargo.toml? You usually don't get warnings if there are any errors - could that be the problem with warnings? |
mpq is the crate I am working on. So basically, RLS cannot find the current project. I have experimented a bit and found that warnings and errors are no longer shown in VSCode. I edited both the source code and the Cargo.toml to introduce syntax errors but they remain unflagged in the UI. The I have made available my current repo here if you want to reproduce the issues For reference, here are my Rust related settings in VSCode "rust.build_lib": true,
"rust.show_warnings": true,
"rust.unstable_features": false |
cc @Xanewok maybe a problem with lib/bin stuff after a forced rebuild? |
I believe this issue is related to rust-lang/rls#431 |
I'll take a look at why the settings doesn't work as expected now. |
@rohel01 is this all fixed now? |
Yes, it is fixed.
Thanks !
2017-08-21 11:32 GMT+02:00 Nick Cameron <notifications@github.com>:
… @rohel01 <https://github.com/rohel01> is this all fixed now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI7wK6GTqSMMPRXHYaW8gb1Avm2ts-Dyks5saU6ygaJpZM4OkhMq>
.
|
I can confirm this issue still exists, and is pretty trivial to hit for new users
|
Can confirm, am new user working through the Guessing Game tutorial and hit this bug, google'd it and landed here. |
same here |
I encountered the same problem through the Guessing Game tutorial. |
FWIW, I wasn't able to reproduce this, so maybe it has been fixed? (macOS, VSCode 1.25.1, rls-vscode 0.4.9, rustup toolchain stable, rustc 1.27.2) |
It's definitely still an issue as I just encountered it! Restarting VSCode fixed it for me |
Unfortunately this occured for Windows for me, fix is pending at https://github.com/Xanewok/rls/tree/windows-watch-cargo |
As sylints said. Same here, running through the Guessing Game tutorial with the latest stable releases as of this writing, ran into the error. Compiles and runs fine regardless. Can also confirm that restarting VSCode fixes it. |
Working through the book, chapter 2 guessing game tutorial generated this problem as well. build and run fine, restart vscode clears, and continues to build and run fine. |
I've also been working on the tutorial and encountered this problem as well. Thanks for reading. |
pulling, this is probably due to an issue with rls-vscode: e.g. rust-lang/vscode-rust#364 and rust-lang/vscode-rust#98. * Other changes that were again meant to be in the previous commit, as mentioned there (rm unused imports, custom_error fixes, compiler fixes such as adding imports and removing unused ones, use the type Error = rror and connection_keep_alive for ProtocolsHandler, etc.) * gossipsub v 0.2.2 -> 0.2.0 * Change remove and remove_peer_from_topic methods of mesh, using a match to return peers or an added custom error. Use in layer. * Compiler fixes: add cloning, return types, etc. *
I just tested the guessing game and it works as expected using RLS from master (should be most recent nightly but is curently breaked for a couple of days) and the most recent VSCode extension. Please reopen if this is still an issue. |
Latest VSCode, Latest Rust (Stable), latest Rust (rls) plugin: Using 'code runner':
ERROR:
Did anyone manage to make VSCode work properly with Rust (rls) plugin? Auto completion seems to be very bad and not always working. I also had to add this flag to the settings.json:
|
Fedora 25 x86_64
VSCode 1.14.2
Rust (rls) 0.1.0
Rust toolchain installed with rustup and up to date.
When adding new crates as dependencies of my library crate, I find that I have to manually restart VSCode so that newly added crates are taken into accound by Rust (rls).
Without restarting, I get the following error in the problem view, although my crate compiles just fine through the command line
The text was updated successfully, but these errors were encountered: