Adding dependencies to Cargo.toml requires restarting VScode

[rohel01]

Fedora 25 x86_64
VSCode 1.14.2
Rust (rls) 0.1.0

Rust toolchain installed with rustup and up to date.

When adding new crates as dependencies of my library crate, I find that I have to manually restart VSCode so that newly added crates are taken into accound by Rust (rls).

Without restarting, I get the following error in the problem view, although my crate compiles just fine through the command line

severity: 'Error'
message: 'use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, and unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)'
at: '7,1'
source: 'rustc'

[nrc]

This should be fixed by updating the RLS (run rustup update from the command line).

[rohel01]

Thanks for the quick response.

I have just updated RLS and it seems to work: RLS monitors my Cargo.toml file and triggers a new analysis when it changes.

The update changed the error message I got and I am not sure it is intended. I am working on the mpq crate which contains both a library and a binary. So, I am using the "rust.build_lib": true setting.

If my Cargo.toml file is missing a crate dependency, I now get the following error

file: 'file:///<removed>/mpq-rust/src/main.rs'
severity: 'Error'
message: 'can't find crate for `mpq`'
at: '3,1'
source: 'rustc'

Also, warning display no longer works ("rust.show_warnings": true in my VSCode settings)

[nrc]

The update changed the error message I got and I am not sure it is intended.

This sounds like the right error? Does it go away when you add the dep for mpq to the Cargo.toml?

You usually don't get warnings if there are any errors - could that be the problem with warnings?

[rohel01]

mpq is the crate I am working on. So basically, RLS cannot find the current project.
Also, this error comes from the main.rs file, while I am working on the library part of the crate. I assumed setting rust.build_lib": true would prevent RLS from analysing that file.

I have experimented a bit and found that warnings and errors are no longer shown in VSCode. I edited both the source code and the Cargo.toml to introduce syntax errors but they remain unflagged in the UI.

The can't find crate for mpq error appears randomly after a few edit/save cycles of my files. When it appears, I usually have to restart VSCode to make it disappear.

I have made available my current repo here if you want to reproduce the issues

For reference, here are my Rust related settings in VSCode

  "rust.build_lib": true,
  "rust.show_warnings": true,
  "rust.unstable_features": false

[nrc]

cc @Xanewok maybe a problem with lib/bin stuff after a forced rebuild?

[rohel01]

I believe this issue is related to rust-lang/rls#431

[Xanewok]

cc @Xanewok maybe a problem with lib/bin stuff after a forced rebuild?

I'll take a look at why the settings doesn't work as expected now.

[nrc]

@rohel01 is this all fixed now?

[rohel01]

Yes, it is fixed. Thanks ! 2017-08-21 11:32 GMT+02:00 Nick Cameron <notifications@github.com>:

…

@rohel01 <https://github.com/rohel01> is this all fixed now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#98 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI7wK6GTqSMMPRXHYaW8gb1Avm2ts-Dyks5saU6ygaJpZM4OkhMq> .

[rlguarino]

I seem to still have this issue:

rustup run nightly rls --version
rls-preview 0.124.0-nightly (299a6a9 2017-12-25)