This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Progress tweaks #772
Merged
Progress tweaks #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rather than only on file opening itself.
This models better what built-in TS/JS services do, in an attempt to be more lazy and less resource-intensive. This addresses a use case where the user may prefer to operate on a monorepo with lots of opened files but keep the sessions short-ish, where they don't touch every project in a single session.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tracking of the active workspace (which is done based on the active text editor rather than last opened file) and also implements tracking of progress per workspace rather than globally. This means that the currently shown progress is for an active workspace rather than last reported one.
This touched some logic related to opening text editors vs changing focus and so in addition to cleaning it up a bit, this now doesn't automatically start RLS instances for each already opened document and added folder. This was done to make the extension lazier (similar to built-in JS/TS service in VSCode) and lighter on the CPU for use cases such as monorepo or short to middle sessions where not every project is opened and edited.