This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Fix document selectors in remote scenarios #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #773
Closes #706 (apart from autocompletion, this should be improved on separately)
cc @jannickj since this touches on patterns again - turns out
RelativePattern
s don't work properly in remote sessions, so I fell back on using fs paths from URIs.Tested on both Xubuntu 19.10 and Windows 10 (Remote WSL + SSH on Xubuntu), including other folders like D:\ and so far so good.