This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Fix the current test harness #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
force-pushed
the
fix-ci-tests
branch
6 times, most recently
from
7834d67 to
95a81e9
Compare
Xanewok
force-pushed
the
fix-ci-tests
branch
2 times, most recently
from
7722a44 to
2cf124f
Compare
It seems that we do not share that on Windows the same way we do on the other platforms, so make sure to go through the 'blessed' way of fetching the public API that's returned by extension's `activate` function. This should fix tests on all platforms.
It ain't pretty but it works.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...since it seems that we do not catch errors properly and erroneously flag them as successful.