This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Bump lodash #817
Merged
Bump lodash #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ EDIT: Oh dear, it's easy to forget we only did set it up for RLS and not for the extension... |
|
@matklad it seems the Windows CI is red due to prettier changes? Wild guess is because it's due to EOL? Would be great if we could figure out if we can cheaply make it pass again for the time of gradual merging but I think we can also work around that |
|
We don't use prettier, we use tsfmt. So I assume that prettier legitimately complains about different formatting. So I would guess that the problem is that we actually only run prettier on Windows, due to different shell glob expansion? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the low severity
npm auditissue.