Skip to content

Use 127.0.0.1 instead of localhost for dev to avoid lookup #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2019
Merged

Use 127.0.0.1 instead of localhost for dev to avoid lookup #681

merged 1 commit into from
Jan 8, 2019

Conversation

spk
Copy link
Contributor

@spk spk commented Jan 2, 2019

Hi just using 127.0.0.1 in Rocket development config instead of localhost to avoid lookup; cheers

@yoshuawuyts
Copy link
Member

@spk could you say more about what this does? Which lookup is removed?

yoshuawuyts
yoshuawuyts approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections

@spk
Copy link
Contributor Author

spk commented Jan 6, 2019

Hi @yoshuawuyts, this just avoid the server to resolv every boot the name localhost to the IP it need to listen to, sorry if my first comment was not clear

@yoshuawuyts
Copy link
Member

@spk all good! -- thanks for the contribution!

@yoshuawuyts yoshuawuyts merged commit 3d9504e into rust-lang:master Jan 8, 2019
@spk spk deleted the use-127-0-0-1-dev branch January 17, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spk @yoshuawuyts