uefi: Return AtaResponse from failed AtaDevice::execute_command()

The AtaResponse contains status register values that help identifying what
went wrong.

Author: seijikun

uefi/CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ## Changed
 - Changed ordering of `proto::pci::PciIoAddress` to (bus -> dev -> fun -> reg -> ext_reg).
+- Return request with status as error data object for `proto::ata::pass_thru::AtaDevice`.
 
 # uefi - v0.36.1 (2025-11-05)
 

uefi/src/proto/ata/pass_thru.rs

@@ -182,20 +182,25 @@ impl AtaDevice<'_> {
     /// - [`Status::UNSUPPORTED`] The host adapter does not support the command described by the ATA command.
     ///   The command was not sent, and no additional status information is available.
     /// - [`Status::TIMEOUT`] A timeout occurred while waiting for the ATA command to execute. Refer to `Asb` for additional status details.
+    #[allow(clippy::result_large_err)]
     pub fn execute_command<'req>(
         &mut self,
         mut req: AtaRequest<'req>,
-    ) -> crate::Result<AtaResponse<'req>> {
+    ) -> crate::Result<AtaResponse<'req>, AtaResponse<'req>> {
         req.packet.acb = &req.acb;
-        unsafe {
+        let result = unsafe {
             ((*self.proto.get()).pass_thru)(
                 self.proto.get(),
                 self.port,
                 self.pmp,
                 &mut req.packet,
                 ptr::null_mut(),
             )
-            .to_result_with_val(|| AtaResponse { req })
+            .to_result()
+        };
+        match result {
+            Ok(_) => Ok(AtaResponse { req }),
+            Err(s) => Err(crate::Error::new(s.status(), AtaResponse { req })),
         }
     }
 }