-
-
Notifications
You must be signed in to change notification settings - Fork 178
Closed
Labels
Description
CI has been red for a while now, due to various problems. At this point, it's not very useful psychologically (does CI fail because the code is broken, or because of the well-known issue with QEMU?).
I propose some changes to the way we currently integrate new code into uefi-rs
:
- make the
master
branch protected, and only allow merging PRs with it- this might eventually require we set up something like
bors
to ensure code onmaster
always compiles. Although at this point it seems unnecessary, we rarely have more than one PR at a time.
- this might eventually require we set up something like
- allow the current CI job which tries to build and run the code in QEMU to fail. We'll fix it, eventually, in Integration Test: Multiprocessor Test fails in QEMU/OVMF #103
- add a new job which runs
cargo check
on all the crates - this will be required for merging - keep the job which runs
cargo fmt
- this will also be required for merging. - perhaps set up a cron job to regularly check if it still builds on latest nightly?
Cc @HadrienG2