nix: update rust-toolchain in shell #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
changed the title
|
Please leave some comments @RaitoBezarius - what do you think? |
2 tasks
phip1611
commented
Nov 14, 2023
| @@ -1,2 +1,5 @@ | |||
| [toolchain] | |||
| channel = "stable" | |||
There was a problem hiding this comment.
I think this is fine: any concerns @nicholasbishop ?
There was a problem hiding this comment.
Seems fine to me, but just for my own edification, why is this part of the change necessary?
There was a problem hiding this comment.
So that rust-bin.fromRustupToolchainFile ../rust-toolchain.toml can pick the right toolchain for Nix.
phip1611
force-pushed
the
nix-shell
branch
2 times, most recently
from
82fcc92 to
e94629d
Compare
nicholasbishop
approved these changes
Nov 15, 2023
Now, a nix-shell always has the latest rust stable version, compliant to our rust-toolchain.toml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rust-toolchain from
rustuptorust-bin.fromRustupToolchainFilecoming from https://github.com/oxalica/rust-overlay. This supersedes #994.TL;DR:
nix-shell --pure --run "rustc --version"is now1.73.Checklist