Skip to content

Conversation

RaitoBezarius
Copy link
Contributor

@RaitoBezarius RaitoBezarius commented Nov 6, 2023

As NixOS 23.11 will be out soon and the shell.nix is broken due to MSRV requirements (23.05 has 1.69.0, not 1.70.0), we can already move to unstable which is "beta 23.11" at this point.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

As NixOS 23.11 will be out soon and the `shell.nix` is broken
due to MSRV requirements (23.05 has 1.69.0, not 1.70.0), we
can already move to unstable which is "beta 23.11" at this point.
@phip1611
Copy link
Member

phip1611 commented Nov 7, 2023

https://github.com/rust-osdev/uefi-rs/blob/main/shell.nix#L20

Hm, our nix shell comes with rustup. We don't use rustc from nixpkgs. What do you mean by it's not working then? rustup installs the proper toolchain.

@RaitoBezarius
Copy link
Contributor Author

RaitoBezarius commented Nov 7, 2023 via email

@phip1611
Copy link
Member

phip1611 commented Nov 7, 2023

I see. Personally, even on Nix, I'm a big rustup fan and don't like the "pure Nix"-way when it comes to Rust in a shell. But I see that some folks don't want to use rustup.

Instead of switching to nixpkgs-unstable, I think, a better solution would be to either
a) use rust-overlay and add the latest stable rust toolchain into the PATH
b) switch to a flake-based shell and provide one rustup shell and one with a pinned rustc.

What do you say?

@phip1611 phip1611 self-assigned this Nov 7, 2023
@RaitoBezarius
Copy link
Contributor Author

I see. Personally, even on Nix, I'm a big rustup fan and don't like the "pure Nix"-way when it comes to Rust in a shell. But I see that some folks don't want to use rustup.

Instead of switching to nixpkgs-unstable, I think, a better solution would be to either a) use rust-overlay and add the latest stable rust toolchain into the PATH b) switch to a flake-based shell and provide one rustup shell and one with a pinned rustc.

I think a) or c) is fine where c) could be just the same setup with 2 shells attribute sets instead of a Flake as I don't think it's necessary at all.

@phip1611
Copy link
Member

Superseded by #1007

@phip1611 phip1611 closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants