Skip to content

Add cargo feature for ignoring logger errors#132

Merged
GabrielMajeri merged 1 commit into
masterfrom
ignore-logger-error-flag
Apr 4, 2020
Merged

Add cargo feature for ignoring logger errors#132
GabrielMajeri merged 1 commit into
masterfrom
ignore-logger-error-flag

Conversation

@HadrienG2
Copy link
Copy Markdown
Contributor

@HadrienG2 HadrienG2 commented Apr 4, 2020

As discussed in the context of #123 , this PR enables configuring whether logger errors should be ignored or not at compile time.

Fixes #123 .

@HadrienG2 HadrienG2 requested a review from GabrielMajeri April 4, 2020 14:53
@HadrienG2 HadrienG2 self-assigned this Apr 4, 2020
@HadrienG2 HadrienG2 linked an issue Apr 4, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@GabrielMajeri GabrielMajeri merged commit 5814c52 into master Apr 4, 2020
@GabrielMajeri GabrielMajeri deleted the ignore-logger-error-flag branch May 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit decision to ignore I/O errors in logging

2 participants