Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo feature for ignoring logger errors #132

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Add cargo feature for ignoring logger errors #132

merged 1 commit into from
Apr 4, 2020

Conversation

HadrienG2
Copy link
Contributor

@HadrienG2 HadrienG2 commented Apr 4, 2020 •
edited
Loading

As discussed in the context of #123 , this PR enables configuring whether logger errors should be ignored or not at compile time.

Fixes #123 .

@HadrienG2 HadrienG2 requested a review from GabrielMajeri April 4, 2020 14:53
@HadrienG2 HadrienG2 self-assigned this Apr 4, 2020
@HadrienG2 HadrienG2 linked an issue Apr 4, 2020 that may be closed by this pull request
Revisit decision to ignore I/O errors in logging #123
Closed
GabrielMajeri
GabrielMajeri approved these changes Apr 4, 2020
View reviewed changes
Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@GabrielMajeri GabrielMajeri merged commit 5814c52 into master Apr 4, 2020
@GabrielMajeri GabrielMajeri deleted the ignore-logger-error-flag branch May 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielMajeri GabrielMajeri GabrielMajeri approved these changes

Assignees

@HadrienG2 HadrienG2

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit decision to ignore I/O errors in logging
2 participants
@HadrienG2 @GabrielMajeri