Skip to content

Conversation

HadrienG2
Copy link
Contributor

@HadrienG2 HadrienG2 commented Sep 23, 2018

As discussed in #1, it would be nice to add GOP test output validation to CI. This PR does so by using the "screendump" functionality of QEMU's monitor.

Implementing this had some side-effects:

  • Serial ports now implement fmt::Write for easily sending UTF-8 strings (removed)
  • The previous "qemu-f4-exit" feature was turned into a more general "qemu" feature which enables all the features that are specific to our QEMU-based test environment.
  • The python script can now chat with the QEMU monitor's JSON interface, which we could use later on for more advanced debugging features like core dumps.
  • I removed all temporizations from automated tests, so they will run a few seconds faster :)

Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HadrienG2 HadrienG2 merged commit 5431761 into rust-osdev:master Sep 23, 2018
@HadrienG2 HadrienG2 deleted the screenshots branch September 23, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants