-
Notifications
You must be signed in to change notification settings - Fork 69
CI: run cargo doc #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: run cargo doc #879
Conversation
@roypat @epilys @RuoqingHe do you think we should add something similar also in https://github.com/rust-vmm/rust-vmm-ci/blob/main/.buildkite/test_description.json ? |
Yes, I think we should. crates.io automatically publishes our documentation to docs.rs, and if cargo doc doesnt work, that might limit discoverability of our crates |
Should I keep going with this PR, or is the idea that it'll be entirely handled in rust-vmm-ci? |
@alyssais unfortunately here in |
Ah, I guess I actually need to fix the staging devices first! |
Link: rust-vmm#877 (comment) Signed-off-by: Alyssa Ross <hi@alyssa.is>
840c67f
to
7f30ad3
Compare
I should be able to |
Summary of the PR
Link: #877 (comment)
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.