build(deps): bump rust-vmm-ci from 589b6b1 to 9751aaa
#258
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
alexandruag,
andreeaflorescu,
jiangliu,
slp,
stsquad and
epilys
as code owners
This warning is new in latest Rust and breaks when updating the CI environment [1]. [1] rust-vmm#258 Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
|
Depends on #263. Not sure why the coverage tanked though... |
This warning is new in latest Rust and breaks when updating the CI environment [1]. [1] #258 Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
|
Can someone do |
|
@dependabot rebase |
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `589b6b1` to `9751aaa`. - [Commits](rust-vmm/rust-vmm-ci@589b6b1...9751aaa) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/submodules/rust-vmm-ci-9751aaa
branch
from
d627bbe
to
f97599f
Compare
Huh?.. |
mmm, strange! Could that be related to rust-vmm/rust-vmm-ci#133 ? @roypat any suggestion? |
|
Considering how big the difference is I don't think is related only to that. I would guess that the tests for some crates are no longer running 🤷♀️ otherwise it doesn't make sense. For the other crates the difference was only a few percentages. |
|
Sorry, I was out sick until today and only saw this now :( I think its because the |
|
@roypat good point! We can also just replace the diff --git a/coverage_config_x86_64.json b/coverage_config_x86_64.json
index bf4b322..5d42b9a 100644
--- a/coverage_config_x86_64.json
+++ b/coverage_config_x86_64.json
@@ -1,5 +1,5 @@
{
"coverage_score": 89.1,
- "exclude_path": "crates/virtio-bindings,crates/virtio-queue/src/mock.rs",
+ "exclude_path": "crates/virtio-bindings|crates/virtio-queue/src/mock.rs",
"crate_features": "virtio-blk/backend-stdio"
}But we need to fix |
|
PR here: rust-vmm/rust-vmm-ci#137 |
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
|
how do we get it to pick up the new commits from rust-vmm-ci? 🤔 |
|
@dependabot recreate |
|
Superseded by #264. |
Bumps rust-vmm-ci from
589b6b1to9751aaa.Commits
9751aaaREADME: Fix link to setup_new_repo.md665f31fAdd Rust unittest so that test_coverage properly self-tests2148c04Update container version to 26412ecd5Have coverage test use llvm-cov instead of cargo-kcov7c1057etest_commit_format: no longer check body length9dfe5b2Use derivatives of BaseException for exceptions7e9af57test: Update code coverage test56bfdc9test: Format withblack285971eUpdate container version to 24Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)